From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 10/20] event/dpaa2: add initialization of
	event device
Date: Thu, 1 Jun 2017 16:09:09 +0530
Message-ID: <20170601103908.GA23495@jerin>
References: <1495735671-4917-1-git-send-email-nipun.gupta@nxp.com>
 <1495735671-4917-11-git-send-email-nipun.gupta@nxp.com>
 <20170531151003.GB16598@jerin>
 <HE1PR0401MB24255ED4D67F9FC79CB66857E6F60@HE1PR0401MB2425.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 "harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "gage.eads@intel.com" <gage.eads@intel.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0073.outbound.protection.outlook.com [104.47.32.73])
 by dpdk.org (Postfix) with ESMTP id 06D927CBB
 for <dev@dpdk.org>; Thu,  1 Jun 2017 12:39:32 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <HE1PR0401MB24255ED4D67F9FC79CB66857E6F60@HE1PR0401MB2425.eurprd04.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Thu, 1 Jun 2017 10:25:02 +0000
> From: Nipun Gupta <nipun.gupta@nxp.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>,
>  "harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
>  "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
>  "gage.eads@intel.com" <gage.eads@intel.com>, Shreyansh Jain
>  <shreyansh.jain@nxp.com>
> Subject: RE: [PATCH 10/20] event/dpaa2: add initialization of event device
> 
> 
> 
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Wednesday, May 31, 2017 20:40
> > To: Nipun Gupta <nipun.gupta@nxp.com>
> > Cc: dev@dpdk.org; Hemant Agrawal <hemant.agrawal@nxp.com>;
> > harry.van.haaren@intel.com; bruce.richardson@intel.com;
> > gage.eads@intel.com; Shreyansh Jain <shreyansh.jain@nxp.com>
> > Subject: Re: [PATCH 10/20] event/dpaa2: add initialization of event device
> > 
> > -----Original Message-----
> > > Date: Thu, 25 May 2017 23:37:41 +0530
> > > From: Nipun Gupta <nipun.gupta@nxp.com>
> > > To: dev@dpdk.org
> > > CC: hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com,
> > >  harry.van.haaren@intel.com, bruce.richardson@intel.com,
> > >  gage.eads@intel.com, shreyansh.jain@nxp.com, Nipun Gupta
> > >  <nipun.gupta@nxp.com>
> > > Subject: [PATCH 10/20] event/dpaa2: add initialization of event device
> > > X-Mailer: git-send-email 1.9.1
> > >
> > > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> > > ---
> > >  drivers/event/dpaa2/dpaa2_eventdev.c | 153
> > ++++++++++++++++++++++++++++++++++-
> > >  drivers/event/dpaa2/dpaa2_eventdev.h |  22 +++++
> > >  2 files changed, 171 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c
> > b/drivers/event/dpaa2/dpaa2_eventdev.c
> > > index 191901e..7fa17f2 100644
> > > --- a/drivers/event/dpaa2/dpaa2_eventdev.c
> > > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c
> > > @@ -30,17 +30,164 @@
> > >   *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> > DAMAGE.
> > >   */
> > >
> > > +#include <assert.h>
> > > +#include <stdio.h>
> > > +#include <stdbool.h>
> > > +#include <errno.h>
> > > +#include <stdint.h>
> > > +#include <string.h>
> > > +#include <stdint.h>
> > > +#include <sys/epoll.h>
> > > +
> > > +#include <rte_byteorder.h>
> > > +#include <rte_common.h>
> > > +#include <rte_debug.h>
> > > +#include <rte_dev.h>
> > >  #include <rte_eal.h>
> > > +#include <rte_log.h>
> > > +#include <rte_memory.h>
> > > +#include <rte_memzone.h>
> > > +#include <rte_malloc.h>
> > > +#include <rte_pci.h>
> > > +#include <rte_lcore.h>
> > >  #include <rte_vdev.h>
> > > +#include <rte_fslmc.h>
> > > +#include <rte_atomic.h>
> > 
> > Maintain alphabetical order in header inclusion.
> 
> Thank you for the review.
> 
> Regarding this I check most of the c files in DPDK and do not see that alphabetical
> being maintained in the header file inclusions. Are you suggesting to have an alphabetical
> order here across all inclusions of rte* as well as gcc standard header files (combined) or
> to have them ordered separately?

Just the rte_*.h header files in the new files.