From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v4 07/12] net/failsafe: support flow API Date: Thu, 1 Jun 2017 11:02:22 -0700 Message-ID: <20170601110222.246a0614@xeon-e3> References: <36220bb3757d1764d5c054f72bfa72193a91040a.1496065002.git.gaetan.rivet@6wind.com> <20170531082139.5ddce6d9@xeon-e3> <20170601142813.GE18840@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: =?UTF-8?B?R2HDq3Rhbg==?= Rivet Return-path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 28B2D7CCE for ; Thu, 1 Jun 2017 20:02:25 +0200 (CEST) Received: by mail-pf0-f173.google.com with SMTP id m17so33728593pfg.3 for ; Thu, 01 Jun 2017 11:02:25 -0700 (PDT) In-Reply-To: <20170601142813.GE18840@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 1 Jun 2017 16:28:13 +0200 Ga=C3=ABtan Rivet wrote: > On Wed, May 31, 2017 at 08:21:39AM -0700, Stephen Hemminger wrote: > > On Mon, 29 May 2017 15:42:19 +0200 > > Gaetan Rivet wrote: > > =20 > > > Signed-off-by: Gaetan Rivet > > > Acked-by: Olga Shern > > > --- > > > doc/guides/nics/features/failsafe.ini | 1 + > > > drivers/net/failsafe/Makefile | 1 + > > > drivers/net/failsafe/failsafe.c | 1 + > > > drivers/net/failsafe/failsafe_eal.c | 1 + > > > drivers/net/failsafe/failsafe_ether.c | 70 +++++++++++ > > > drivers/net/failsafe/failsafe_flow.c | 216 ++++++++++++++++++++++= ++++++++++ > > > drivers/net/failsafe/failsafe_ops.c | 29 +++++ > > > drivers/net/failsafe/failsafe_private.h | 18 +++ > > > 8 files changed, 337 insertions(+) > > > create mode 100644 drivers/net/failsafe/failsafe_flow.c =20 > >=20 > > How does this interact with typical case of VF and dumb virtual device? > > The VF has flow API but dumb virtual device does not. > > =20 >=20 > The fail-safe requires capabilities to be the same on all its slave. If > a capability must be supported on the VF, then is should be as well on > the synthetic path. >=20 > But the TAP PMD that can be used to capture traffic from a synthetic > path supports rte_flow in the same capacity as other NICs. >=20 > > How does this work with late binding plugin? If VF arrives later is > > the flow table reprogrammed to the VF? =20 >=20 > The fail-safe stores an internal representation of rte_flows. These are > replayed in the same order upon plugin, so the flow table is > reprogrammed in the same way to the VF. >=20 The synthetic path can't do flow direction in netvsc (and via tap). Therefo= re this whole flow direction part is uninteresting for the use case of Hyper-V/Azure.