From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC] Add Membership Library
Date: Fri, 2 Jun 2017 13:51:31 -0700
Message-ID: <20170602135131.25fae7f7@xeon-e3>
References: <1495848888-54621-1-git-send-email-yipeng1.wang@intel.com>
 <15c49491fa0.27fc.bb328046f2889bc8f44aafa891a44dd2@6wind.com>
 <D2C4A16CA39F7F4E8E384D204491D7A640717076@ORSMSX105.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Vincent Jardin <vincent.jardin@6wind.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Gobriel, Sameh" <sameh.gobriel@intel.com>, "Wang, Ren"
 <ren.wang@intel.com>, "Tai, Charlie" <charlie.tai@intel.com>
To: "Wang, Yipeng1" <yipeng1.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com
 [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id EDB667D0D
 for <dev@dpdk.org>; Fri,  2 Jun 2017 22:51:38 +0200 (CEST)
Received: by mail-pf0-f176.google.com with SMTP id m17so56909992pfg.3
 for <dev@dpdk.org>; Fri, 02 Jun 2017 13:51:38 -0700 (PDT)
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A640717076@ORSMSX105.amr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 1 Jun 2017 01:03:36 +0000
"Wang, Yipeng1" <yipeng1.wang@intel.com> wrote:

> Hi Vincent,
> 
> Thanks for the comments and some quick responses below:
> 
> - DPDK Bloom Filter is derived from the libbloom (as shown by the included BSD license), but optimized for performance with various DPDK goodness such as rte_zmalloc, rte_bitmap, rte_jhash, etc. It doesn't seem appropriate to    bring those DPDK specific features into libbloom, which is designed for more generic environments.
> - DPDK Bloom Filter is just one very basic mode among other more sophisticated ones in the DPDK Membership Library, which supports a different set of APIs (e.g., bulk lookup, multi-match, etc.) than those supported in libbloom.
> - It may make sense to bring some generic (i.e., non DPDK specific) improvements back to libbloom once identified.
> 
> Thanks
> Yipeng
> 
> > -----Original Message-----
> > From: Vincent Jardin [mailto:vincent.jardin@6wind.com]
> > Sent: Saturday, May 27, 2017 2:42 AM
> > To: Wang, Yipeng1 <yipeng1.wang@intel.com>
> > Cc: dev@dpdk.org; Gobriel, Sameh <sameh.gobriel@intel.com>; Wang, Ren
> > <ren.wang@intel.com>; Tai, Charlie <charlie.tai@intel.com>
> > Subject: Re: [dpdk-dev] [RFC] Add Membership Library
> > 
> > Why duplicating Jyri's libbloom - https://github.com/jvirkki/libbloom - for this
> > DPDK capability? Why not showing that you can contribute to libbloom and
> > make it linkable with the DPDK?
> > 
> > There are so many duplicated code...
> > 
> > Thank you,
> >   Vincent
> >   
> 

Note: rte_zmalloc is really no faster in my experience than regular malloc. And under
memory pressure rte_malloc is worse than malloc.