From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yliu@fridaylinux.org>
Subject: Re: [dpdk-stable]  [PATCH] vhost: fix crash on NUMA
Date: Sun, 4 Jun 2017 11:08:29 +0800
Message-ID: <20170604030430.GA10168@yliu-home>
References: <1496362486-1741-1-git-send-email-yuanhan.liu@linux.intel.com>
 <20170602082038.cnuizul6wrfgdesi@dhcp-192-218.str.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>, stable@dpdk.org
To: Jens Freimann <jfreiman@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66])
 by dpdk.org (Postfix) with ESMTP id DE49C7CDF
 for <dev@dpdk.org>; Sun,  4 Jun 2017 05:08:37 +0200 (CEST)
Received: by mail-pg0-f66.google.com with SMTP id v14so2331406pgn.1
 for <dev@dpdk.org>; Sat, 03 Jun 2017 20:08:37 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20170602082038.cnuizul6wrfgdesi@dhcp-192-218.str.redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 02, 2017 at 10:20:38AM +0200, Jens Freimann wrote:
> On Fri, Jun 02, 2017 at 08:14:46AM +0800, Yuanhan Liu wrote:
> > The queue allocation was changed, from allocating one queue-pair at a
> > time to one queue at a time. Most of the changes have been done, but
> > just with one being missed: the size of coping the old queue is still
> 
> s/coping/copying/ ?

right, thanks.

> 
> > based on queue-pair at numa_realloc(), which leads to overwritten issue.
> > As a result, crash may happen.
> > 
> > Fix it by specifying the right copy size. Also, the net queue macros
> > are not used any more. Remove them.
> > 
> > Fixes: ab4d7b9f1afc ("vhost: turn queue pair to vring")
> > 
> > Cc: stable@dpdk.org
> > Reported-by: Ciara Loftus <ciara.loftus@intel.com>
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > ---
> >  lib/librte_vhost/vhost_user.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> 
> Reviewed-by: Jens Freimann <jfreiman@redhat.com>

Applied to dpdk-next-virtio.

	--yliu