From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v2 08/12] kni: disabled by default
Date: Fri, 9 Jun 2017 11:06:09 +0200
Message-ID: <20170609090609.GC29091@bidouze.vm.6wind.com>
References: <cover.1496877060.git.gaetan.rivet@6wind.com>
 <efb0da489bea9ed32ac8d20fb83b9e390d5d1d51.1496877060.git.gaetan.rivet@6wind.com>
 <015f5ab0-1936-44f3-a60e-f4ff9f377262@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 8E0EE378B
 for <dev@dpdk.org>; Fri,  9 Jun 2017 11:06:18 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id d73so45705614wma.0
 for <dev@dpdk.org>; Fri, 09 Jun 2017 02:06:18 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <015f5ab0-1936-44f3-a60e-f4ff9f377262@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On Fri, Jun 09, 2017 at 09:56:14AM +0100, Ferruh Yigit wrote:
> On 6/8/2017 12:59 AM, Gaetan Rivet wrote:
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> >  config/common_linuxapp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/config/common_linuxapp b/config/common_linuxapp
> > index b3cf41b..cc85cc6 100644
> > --- a/config/common_linuxapp
> > +++ b/config/common_linuxapp
> > @@ -38,7 +38,7 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> >  CONFIG_RTE_EAL_IGB_UIO=y
> >  CONFIG_RTE_EAL_VFIO=y
> >  CONFIG_RTE_KNI_KMOD=y
> > -CONFIG_RTE_LIBRTE_KNI=y
> > +CONFIG_RTE_LIBRTE_KNI=n
> >  CONFIG_RTE_LIBRTE_PMD_KNI=y
> >  CONFIG_RTE_LIBRTE_VHOST=y
> >  CONFIG_RTE_LIBRTE_PMD_VHOST=y
> > 
> 
> Hi Gaetan,
> 
> We shouldn't just disable components that doesn't compile.
> 

Ah, sure :) . This patch is not meant to be integrated as is, but only
as a convenient way for testers to apply the patchset and verify the
compilation, as far as KNI is not concerned.

Eventdev and cryptodev fixed this dependency. I was thinking about
looking into it for KNI and PDUMP but I don't have the time right now,
and I'm not sure I will have until the end of June.

> And what happens when it is enabled, not compiled at all? So you are
> literally breaking the existing support with your patch?
> 
> Thanks,
> ferruh
> 

-- 
Gaëtan Rivet
6WIND