From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] virtio: fix PCI config err handling Date: Mon, 12 Jun 2017 18:31:45 +0800 Message-ID: <20170612103145.GB2611@yliu-home> References: <1496677473-17893-1-git-send-email-brussell@brocade.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Maxime Coquelin , dev@dpdk.org To: Brian Russell Return-path: Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 07A4CDE3 for ; Mon, 12 Jun 2017 12:31:53 +0200 (CEST) Received: by mail-pg0-f68.google.com with SMTP id v14so13950049pgn.1 for ; Mon, 12 Jun 2017 03:31:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1496677473-17893-1-git-send-email-brussell@brocade.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 05, 2017 at 04:44:33PM +0100, Brian Russell wrote: > In virtio_read_caps, rte_pci_read_config returns the number of bytes > read from PCI config or <0 on error. > If less than the expected number of bytes are read then log the > failure and return rather than carrying on with garbage. > > Signed-off-by: Brian Russell > --- > drivers/net/virtio/virtio_pci.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c > index b7b3d61..90c098e 100644 > --- a/drivers/net/virtio/virtio_pci.c > +++ b/drivers/net/virtio/virtio_pci.c > @@ -592,16 +592,18 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw) > } > > ret = rte_pci_read_config(dev, &pos, 1, PCI_CAPABILITY_LIST); > - if (ret < 0) { > - PMD_INIT_LOG(DEBUG, "failed to read pci capability list"); > + if (ret != 1) { > + PMD_INIT_LOG(DEBUG, > + "failed to read pci capability list, ret %d", ret); > return -1; > } There are two things worth mentioning: - rte_pci.h states nothing about the return value - The BSD implementation actually returns 0 on success, while the Linux implementation indeed returns the bytes read. --yliu