From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v2 07/12] pdump: disabled by default
Date: Wed, 14 Jun 2017 11:20:38 +0200
Message-ID: <20170614092038.GV29091@bidouze.vm.6wind.com>
References: <cover.1496877060.git.gaetan.rivet@6wind.com>
 <87a12a85ab782a5995100ea1e2ae80a2c7e0ec5e.1496877060.git.gaetan.rivet@6wind.com>
 <3AEA2BF9852C6F48A459DA490692831F2A2133A4@irsmsx110.ger.corp.intel.com>
 <20170611194225.GO29091@bidouze.vm.6wind.com>
 <3AEA2BF9852C6F48A459DA490692831F2A215644@irsmsx110.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com
 [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id E395D7CEE
 for <dev@dpdk.org>; Wed, 14 Jun 2017 11:20:47 +0200 (CEST)
Received: by mail-wr0-f172.google.com with SMTP id q97so180282337wrb.2
 for <dev@dpdk.org>; Wed, 14 Jun 2017 02:20:47 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A215644@irsmsx110.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 14, 2017 at 09:09:18AM +0000, Pattan, Reshma wrote:
> Hi,
> 
> > -----Original Message-----
> > From: Gaëtan Rivet [mailto:gaetan.rivet@6wind.com]
> > Sent: Sunday, June 11, 2017 8:42 PM
> > To: Pattan, Reshma <reshma.pattan@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v2 07/12] pdump: disabled by default
> > 
> > >
> > > Since, you already mentioned in other mail to Ferruh that config flag
> > disabling patches are only for testers compilation purpose and you have
> > plans to make proper fix by end of June.  I will wait on for actual patch.
> > >
> > 
> > I said I planned to do so, but found out that I would not have enough time
> > before the end of June. Sorry about the ambiguous phrasing.
> > 
> > Do you think you will be able to fix this library in time?
> 
> rte_pci.h is unnecessary include in rte_pdump.c, hence I removed it and sent the patch.
> 

I tested it, no problem.
The patch disabling pdump will be removed from the next version. Thanks.

> Thanks,
> Reshma 
> 
> 

-- 
Gaëtan Rivet
6WIND