From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v4 05/19] net/ixgbe: properly reference PCI
 header
Date: Wed, 14 Jun 2017 11:48:28 +0200
Message-ID: <20170614094827.GW29091@bidouze.vm.6wind.com>
References: <cover.1496876859.git.gaetan.rivet@6wind.com>
 <0a60f041662ae5aec08d0ee9ba9795fc07292d62.1496876859.git.gaetan.rivet@6wind.com>
 <49759EB36A64CF4892C1AFEC9231E8D650AA51FA@PGSMSX106.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Dai, Wei" <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com
 [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 9082C7CEB
 for <dev@dpdk.org>; Wed, 14 Jun 2017 11:48:38 +0200 (CEST)
Received: by mail-wr0-f169.google.com with SMTP id v104so170358148wrb.0
 for <dev@dpdk.org>; Wed, 14 Jun 2017 02:48:38 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650AA51FA@PGSMSX106.gar.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On Wed, Jun 14, 2017 at 09:33:14AM +0000, Dai, Wei wrote:
> Why to introduce this change ?
> 
> Even without this patch, all files can be built successfully.
> Each.*.o.d files in x86_64-native-linuxapp-gcc keeps same in both with and without this patch.
> So there is no need to add the line at least in the config of x86_64-native-linuxapp-gcc.
> 
> 

In order to remove the PCI bus from the EAL, I need to remove all
references to it from EAL headers.

rte_devargs.h previously included rte_pci.h, which then was included by
several other parts of the DPDK.

This needs to be fixed, as afterward, the commit

* devargs: generic device representation

removes the PCI include.

This include was faulty anyway, as normally all compile units (or at
least independent DPDK parts) should be self-sufficient in terms of includes,
due to this exact situation where libraries are moved around and their
dependencies are updated.

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet
> > Sent: Thursday, June 8, 2017 7:57 AM
> > To: dev@dpdk.org
> > Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
> > Subject: [dpdk-dev] [PATCH v4 05/19] net/ixgbe: properly reference PCI header
> > 
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h
> > b/drivers/net/ixgbe/ixgbe_ethdev.h
> > index e2d0139..bb5ecd5 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.h
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
> > @@ -39,6 +39,7 @@
> >  #include "ixgbe_bypass.h"
> >  #include <rte_time.h>
> >  #include <rte_hash.h>
> > +#include <rte_pci.h>
> > 
> >  /* need update link, bit flag */
> >  #define IXGBE_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)
> > --
> > 2.1.4
> 

-- 
Gaëtan Rivet
6WIND