From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v2] test/test_mbuf: remove mempool global var Date: Tue, 20 Jun 2017 16:22:56 +0800 Message-ID: <20170620082256.GA436@yliu-home> References: <20170608142831.28166-1-santosh.shukla@caviumnetworks.com> <2170817.cQF1WCe9mM@xps> <2118823.ueSLhbdIFl@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: santosh , dev@dpdk.org, olivier.matz@6wind.com, shreyansh.jain@nxp.com, stable@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 315202C72 for ; Tue, 20 Jun 2017 10:23:04 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id w12so21447192pfk.0 for ; Tue, 20 Jun 2017 01:23:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <2118823.ueSLhbdIFl@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 20, 2017 at 09:35:07AM +0200, Thomas Monjalon wrote: > 20/06/2017 06:14, santosh: > > On Tuesday 20 June 2017 02:07 AM, Thomas Monjalon wrote: > > > > > 08/06/2017 16:28, Santosh Shukla: > > >> Let test_mbuf alloc and free mempool. > > >> > > >> Cc: stable@dpdk.org > > >> Signed-off-by: Santosh Shukla > > > Why Cc stable? > > > Is it fixing something? > > > > > w/o this fix, application can't run more than once. > > Reason: Static allocation of resources and exiting w/o freeing so leak. > > > > Patch makes app resource handling dynamic and Now user could run > > test more than once and app exits gracefully. thats why Cc: stable a need (IHMO). > > Thanks. > > OK > So we need a Fixes: tag in order to be able to guess which > release it should be backported to. Also, I would suggest you to include above info (the real issue) in the commit log. --yliu