From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo de Lara Subject: [PATCH 10/22] examples/l2fwd-crypto: move IV to crypto op private data Date: Wed, 21 Jun 2017 08:47:19 +0100 Message-ID: <20170621074731.45013-10-pablo.de.lara.guarch@intel.com> References: <20170621074731.45013-1-pablo.de.lara.guarch@intel.com> Cc: dev@dpdk.org To: pablo.de.lara.guarch@intel.com Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D4F377CD7 for ; Wed, 21 Jun 2017 17:47:25 +0200 (CEST) In-Reply-To: <20170621074731.45013-1-pablo.de.lara.guarch@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Usually, IV will change for each crypto operation. Therefore, instead of pointing at the same location, IV is copied after each crypto operation. This will let the IV to be passed as an offset from the beginning of the crypto operation, instead of a pointer. Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 779b4fb..f6da8a2 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -89,6 +89,10 @@ enum cdev_type { #define MAX_PKT_BURST 32 #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */ +#define MAXIMUM_IV_LENGTH 16 +#define IV_OFFSET (sizeof(struct rte_crypto_op) + \ + sizeof(struct rte_crypto_sym_op)) + /* * Configurable number of RX/TX ring descriptors */ @@ -480,8 +484,14 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m, } if (cparams->do_cipher) { - op->sym->cipher.iv.data = cparams->iv.data; - op->sym->cipher.iv.phys_addr = cparams->iv.phys_addr; + uint8_t *IV_ptr = rte_crypto_op_ctod_offset(op, uint8_t *, + IV_OFFSET); + /* Copy IV at the end of the crypto operation */ + rte_memcpy(IV_ptr, cparams->iv.data, cparams->iv.length); + + op->sym->cipher.iv.data = IV_ptr; + op->sym->cipher.iv.phys_addr = + rte_crypto_op_ctophys_offset(op, IV_OFFSET); op->sym->cipher.iv.length = cparams->iv.length; /* For wireless algorithms, offset/length must be in bits */ @@ -1950,7 +1960,6 @@ reserve_key_memory(struct l2fwd_crypto_options *options) options->iv.data = rte_malloc("iv", MAX_KEY_SIZE, 0); if (options->iv.data == NULL) rte_exit(EXIT_FAILURE, "Failed to allocate memory for IV"); - options->iv.phys_addr = rte_malloc_virt2phy(options->iv.data); options->aad.data = rte_malloc("aad", MAX_KEY_SIZE, 0); if (options->aad.data == NULL) @@ -1993,7 +2002,7 @@ main(int argc, char **argv) /* create crypto op pool */ l2fwd_crypto_op_pool = rte_crypto_op_pool_create("crypto_op_pool", - RTE_CRYPTO_OP_TYPE_SYMMETRIC, NB_MBUF, 128, 0, + RTE_CRYPTO_OP_TYPE_SYMMETRIC, NB_MBUF, 128, MAXIMUM_IV_LENGTH, rte_socket_id()); if (l2fwd_crypto_op_pool == NULL) rte_exit(EXIT_FAILURE, "Cannot create crypto op pool\n"); -- 2.9.4