From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v8 2/4] unci: add kernel control path kernel
 module
Date: Wed, 21 Jun 2017 08:23:23 -0700
Message-ID: <20170621082323.3c39a2d0@xeon-e3>
References: <20170526165228.96919-1-ferruh.yigit@intel.com>
 <20170621110651.75299-1-ferruh.yigit@intel.com>
 <20170621110651.75299-3-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, anatoly.burakov@intel.com, Bruce Richardson
 <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com
 [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id 1F08F2BC3
 for <dev@dpdk.org>; Wed, 21 Jun 2017 17:23:30 +0200 (CEST)
Received: by mail-pf0-f181.google.com with SMTP id s66so86285955pfs.1
 for <dev@dpdk.org>; Wed, 21 Jun 2017 08:23:30 -0700 (PDT)
In-Reply-To: <20170621110651.75299-3-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 21 Jun 2017 12:06:49 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> +static struct ethtool_input_buffer {
> +	int magic;
> +	void *buffer;
> +	size_t length;
> +	struct completion *msg_received;
> +	int *err;
> +	u32 in_use;
> +} ethtool_input_buffer

Naming in kernel is important. This isn't kernel ethtool, so  it shouldn't be named that.

Having a single instance per system for a control interface means it won't work
if multiple apps have control channel open or in containers.

You should also do policy validation on the netlink message.