From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v3 4/9] bus: properly include rte_debug Date: Wed, 21 Jun 2017 11:26:38 +0200 Message-ID: <20170621092637.GC2344@bidouze.vm.6wind.com> References: <4a5ed1297b9b79329179e8aae8fd336bf98f6b97.1497999952.git.gaetan.rivet@6wind.com> <1948577.YXIUannuor@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 4F00C37A6 for ; Wed, 21 Jun 2017 11:26:47 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id y25so87228901wrd.2 for ; Wed, 21 Jun 2017 02:26:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1948577.YXIUannuor@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 21, 2017 at 09:45:12AM +0200, Thomas Monjalon wrote: > 21/06/2017 01:36, Gaetan Rivet: > > Signed-off-by: Gaetan Rivet > > Please add a comment to explain why this include is required now. This commit will have this comment in the next version: This include is necessary for rte_bus, but it is currently brought by eal_private.h including rte_pci.h, including rte_debug.h. rte_pci.h will move out of the EAL. All compilation units should be self-sufficient include-wise. Cheers, -- Gaëtan Rivet 6WIND