From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v3 5/9] pmdinfogen: move to drivers subdirectory Date: Wed, 21 Jun 2017 11:40:26 +0200 Message-ID: <20170621094026.GD2344@bidouze.vm.6wind.com> References: <78a1d2393d08ec3152f01be35d29401447ce616f.1497999952.git.gaetan.rivet@6wind.com> <8418992.7tWpiUoDtu@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 29B79548B for ; Wed, 21 Jun 2017 11:40:37 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id r103so126996126wrb.0 for ; Wed, 21 Jun 2017 02:40:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <8418992.7tWpiUoDtu@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote: > 21/06/2017 01:36, Gaetan Rivet: > > pmdinfogen has a dependency on the PCI bus. The latter must be built > > first. > > I think it should not be moved outside of buildtools. > Right, I agree. I took the simplest path here, but if there is a better solution to be found I'd prefer to use it. > The build order can be fixed by installing headers before any compilation > like proposed in this RFC: http://dpdk.org/patch/25463 > This RFC should be discussed on its own merit, I will chime in the relevant thread. > Another (probably better) solution is to keep basic definitions > and helpers in EAL: > - rte_pci.h keeps only some PCI definitions and helpers > like rte_pci_addr and eal_parse_pci_BDF() in EAL > - bus management is done in the PCI driver > > For pmdinfogen, we just need struct rte_pci_id. > Other tools or applications will probably need this kind of basic > struct and functions available in EAL. I mostly agree, this proposal should be kept to a minimum at first for this release and carefully expanded afterward. If that's ok, I will propose a new version of this patchset with a new librte_pci, that might fix both pmdinfogen and librte_kni. -- Gaëtan Rivet 6WIND