From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] eventdev: define the default value for dequeue timeout Date: Wed, 21 Jun 2017 17:08:03 +0530 Message-ID: <20170621113801.GB31460@jerin> References: <20170518084827.13626-1-jerin.jacob@caviumnetworks.com> <20170602143830.GA17430@jerin> <20170620154801.GB8453@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com, gage.eads@intel.com, nipun.gupta@nxp.com, narender.vangati@intel.com To: Hemant Agrawal Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0073.outbound.protection.outlook.com [104.47.41.73]) by dpdk.org (Postfix) with ESMTP id 57CD84BE1 for ; Wed, 21 Jun 2017 13:38:25 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170620154801.GB8453@jerin> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Tue, 20 Jun 2017 21:18:01 +0530 > From: Jerin Jacob > To: Hemant Agrawal > Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com, > gage.eads@intel.com, nipun.gupta@nxp.com, narender.vangati@intel.com > Subject: Re: [PATCH] eventdev: define the default value for dequeue timeout > User-Agent: Mutt/1.8.3 (2017-05-23) > > -----Original Message----- > > Date: Fri, 2 Jun 2017 20:08:30 +0530 > > From: Jerin Jacob > > To: Hemant Agrawal > > Cc: dev@dpdk.org, bruce.richardson@intel.com, harry.van.haaren@intel.com, > > gage.eads@intel.com, nipun.gupta@nxp.com, narender.vangati@intel.com > > Subject: Re: [PATCH] eventdev: define the default value for dequeue timeout > > User-Agent: Mutt/1.8.3 (2017-05-23) > > > > -----Original Message----- > > > Date: Thu, 18 May 2017 19:45:44 +0530 > > > From: Hemant Agrawal > > > To: Jerin Jacob , dev@dpdk.org > > > CC: bruce.richardson@intel.com, harry.van.haaren@intel.com, > > > gage.eads@intel.com, nipun.gupta@nxp.com, narender.vangati@intel.com > > > Subject: Re: [PATCH] eventdev: define the default value for dequeue timeout > > > User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 > > > Thunderbird/45.8.0 > > > > > > On 5/18/2017 2:18 PM, Jerin Jacob wrote: > > > > Defining the value 0 as default value for dequeue timeout > > > > will help the application reduce the configuration setup > > > > if the application is interested only in default > > > > timeout value. > > > > > > > > Signed-off-by: Jerin Jacob > > > > --- > > > > This patch will fix following error found in the event_pipeline RFC application > > > > http://dpdk.org/dev/patchwork/patch/23799/ with event_octeontx HW driver. > > > > > > > > EVENTDEV: rte_event_dev_configure() line 379: dev0 invalid > > > > dequeue_timeout_ns=0 min_dequeue_timeout_ns=853 max_dequeue_timeout_ns=873813 > > > > --- > > > > drivers/event/octeontx/ssovf_evdev.c | 2 ++ > > > > lib/librte_eventdev/rte_eventdev.c | 5 +++-- > > > > lib/librte_eventdev/rte_eventdev.h | 1 + > > > > 3 files changed, 6 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c > > > > index c80a44379..5499b1bf7 100644 > > > > --- a/drivers/event/octeontx/ssovf_evdev.c > > > > +++ b/drivers/event/octeontx/ssovf_evdev.c > > > > @@ -194,6 +194,8 @@ ssovf_configure(const struct rte_eventdev *dev) > > > > > > > > ssovf_func_trace(); > > > > deq_tmo_ns = conf->dequeue_timeout_ns; > > > > + if (deq_tmo_ns == 0) > > > > + deq_tmo_ns = edev->min_deq_timeout_ns; > > > > > > '0' should mean don't wait? > > > > Yes. I think, we can leave that to the driver for the minimum supported > > dequeue timeout for the given platform(PMD). OCTEONTX PMD needs > > different treatment for "no-wait" case, hence setting the minimum value > > that PMD supports. > > > > Any other comments on API change? > > Let me know _if_ there is any objection to take this patch? Applied to dpdk-next-eventdev/master. Thanks.