From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 14/33] app/testeventdev: order: add eventdev
 port setup
Date: Fri, 23 Jun 2017 18:15:25 +0530
Message-ID: <20170623124524.GA1140@jerin>
References: <20170528195854.6064-1-jerin.jacob@caviumnetworks.com>
 <20170528195854.6064-15-jerin.jacob@caviumnetworks.com>
 <E923DB57A917B54B9182A2E928D00FA640C31555@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
 "Eads, Gage" <gage.eads@intel.com>,
 "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
 "Vangati, Narender" <narender.vangati@intel.com>,
 "Rao, Nikhil" <nikhil.rao@intel.com>,
 "gprathyusha@caviumnetworks.com" <gprathyusha@caviumnetworks.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0067.outbound.protection.outlook.com [104.47.38.67])
 by dpdk.org (Postfix) with ESMTP id 89F22F94
 for <dev@dpdk.org>; Fri, 23 Jun 2017 14:46:14 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA640C31555@IRSMSX102.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 23 Jun 2017 12:36:47 +0000
> From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
>  <dev@dpdk.org>
> CC: "Richardson, Bruce" <bruce.richardson@intel.com>,
>  "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Eads, Gage"
>  <gage.eads@intel.com>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
>  "Vangati, Narender" <narender.vangati@intel.com>, "Rao, Nikhil"
>  <nikhil.rao@intel.com>, "gprathyusha@caviumnetworks.com"
>  <gprathyusha@caviumnetworks.com>
> Subject: RE: [dpdk-dev] [PATCH 14/33] app/testeventdev: order: add eventdev
>  port setup
> 
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Sunday, May 28, 2017 8:59 PM
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>;
> > nipun.gupta@nxp.com; Vangati, Narender <narender.vangati@intel.com>; Rao, Nikhil
> > <nikhil.rao@intel.com>; gprathyusha@caviumnetworks.com; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH 14/33] app/testeventdev: order: add eventdev port setup
> > 
> > Setup one port per worker and link to all queues and setup
> > one producer port to inject the events.
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> One suggestion below to increase the enqueue depth, or was there a reason set it to 8?

No specific reason. I think, In some example, SW driver was configuring to 8.
So I choose to select 8. I will change to 32 as you suggested.

> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> 
> <snip some code>
> 
> > +	/* setup one port per worker, linking to all queues */
> > +	for (port = 0; port < nb_workers; port++) {
> > +		struct worker_data *w = &t->worker[port];
> > +
> > +		w->dev_id = opt->dev_id;
> > +		w->port_id = port;
> > +		w->t = t;
> > +
> > +		ret = rte_event_port_setup(opt->dev_id, port, &wkr_p_conf);
> > +		if (ret) {
> > +			evt_err("failed to setup port %d", port);
> > +			return ret;
> > +		}
> > +
> > +		ret = rte_event_port_link(opt->dev_id, port, NULL, NULL, 0);
> > +		if (ret != nb_queues) {
> > +			evt_err("failed to link all queues to port %d", port);
> > +			return -EINVAL;
> > +		}
> > +	}
> > +	/* port for producer, no links */
> > +	const struct rte_event_port_conf prod_conf = {
> > +			.dequeue_depth = 8,
> > +			.enqueue_depth = 8,
> 
> .enqueue_depth = 32 or so?
>