From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v5 03/12] bus: add helper to find which bus
 holds a device
Date: Tue, 27 Jun 2017 00:16:16 +0200
Message-ID: <20170626221616.GP2344@bidouze.vm.6wind.com>
References: <cover.1498436062.git.gaetan.rivet@6wind.com>
 <7250ec82b1b0a8ce1852327dc35d7155c08c7570.1498436062.git.gaetan.rivet@6wind.com>
 <20170626163145.GC101992@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Jan Blunck <jblunck@infradead.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 87EA5235
 for <dev@dpdk.org>; Tue, 27 Jun 2017 00:16:26 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id i127so10110278wma.0
 for <dev@dpdk.org>; Mon, 26 Jun 2017 15:16:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20170626163145.GC101992@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jun 26, 2017 at 05:31:45PM +0100, Bruce Richardson wrote:
> On Mon, Jun 26, 2017 at 02:22:01AM +0200, Gaetan Rivet wrote:
> > From: Jan Blunck <jblunck@infradead.org>
> > 
> > Signed-off-by: Jan Blunck <jblunck@infradead.org>
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> >  lib/librte_eal/bsdapp/eal/rte_eal_version.map   |  1 +
> >  lib/librte_eal/common/eal_common_bus.c          | 25 +++++++++++++++++++++++++
> >  lib/librte_eal/common/include/rte_bus.h         |  5 +++++
> >  lib/librte_eal/linuxapp/eal/rte_eal_version.map |  1 +
> >  4 files changed, 32 insertions(+)
> > 
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Would it be useful to add a unit test for this function? That would help
> with any future refactoring, and also indirectly test the other
> functions added in the previous 2 patches.

Yes, I think it would be better to have unit-tests for those functions.
They can be a little tricky to get right, working with the layers of
callbacks.

I may be short on time for the next version though. I'll see.

-- 
Gaëtan Rivet
6WIND