From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v5 00/12] bus: attach / detach API
Date: Tue, 27 Jun 2017 16:48:22 +0200
Message-ID: <20170627144821.GD13355@bidouze.vm.6wind.com>
References: <cover.1498436062.git.gaetan.rivet@6wind.com>
 <20170627140816.GK104744@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Jan Blunck <jblunck@infradead.org>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 1117B2C08
 for <dev@dpdk.org>; Tue, 27 Jun 2017 16:48:30 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id b184so29209772wme.1
 for <dev@dpdk.org>; Tue, 27 Jun 2017 07:48:30 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20170627140816.GK104744@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jun 27, 2017 at 03:08:17PM +0100, Bruce Richardson wrote:
> On Mon, Jun 26, 2017 at 02:21:58AM +0200, Gaetan Rivet wrote:
> > Following the work from Jan:
> > 
> > This patchset introduces the attach / detach API to rte_bus.
> > The rte_device structure is used as the generic device representation.
> > 
> > This API is implemented for the virtual bus.
> > The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to
> > use this new interface.
> > 
> Other than my opens on patch 12, this set all looks good to me. The
> other comments I made are mostly just suggestions.
> 
> Hopefully next version can be merged.

Thanks for the review, your remarks were useful.
I will send the new version shortly.

> 
> Regards,
> /Bruce

-- 
Gaëtan Rivet
6WIND