From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v4 0/6] Reproducible build Date: Wed, 28 Jun 2017 17:04:09 +0100 Message-ID: <20170628160409.GA7876@bricha3-MOBL3.ger.corp.intel.com> References: <20170623184153.24488-1-lboccass@brocade.com> <20170628135702.18150-1-lboccass@brocade.com> <20170628085733.10153207@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: lboccass@brocade.com, dev@dpdk.org, Luca Boccassi To: Stephen Hemminger Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1F4A72904 for ; Wed, 28 Jun 2017 18:04:12 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170628085733.10153207@xeon-e3> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 28, 2017 at 08:57:33AM -0700, Stephen Hemminger wrote: > On Wed, 28 Jun 2017 14:56:56 +0100 > wrote: > > > From: Luca Boccassi > > > > In the past couple of years a concerted effort among almost all Linux > > distros has been striving toward achieving reproducible builds. [1] > > This involves changes to the toolchain, new tools and CI systems. [2] > > > > v1 fixed the documentation, examples and linker script generation. > > v2 fixes all problems, which were caused by unstable order of headers > > inclusion, source files listing and object file listing when passing > > them to the compiler. > > DPDK's build, at least with the default configuration, is fully > > reproducible with this patch series as tested by the Reproducible > > Builds developers experimental toolchain. [3] > > > > v3 restores the first patch, which was eaten by git send-email. > > > > v4 drops the patch that reorders rebuilds, and adds a patch to make > > the inclusion of headers deterministic with regards to GCC embedding > > the full file path when expading __FILE__ and when writing the > > directory listing in the DWARF objects. > > It also drops the first 2 patches which have already been merged. > > > > [1] https://reproducible-builds.org/ > > [2] https://reproducible-builds.org/tools/ > > [3] https://wiki.debian.org/ReproducibleBuilds/ExperimentalToolchain#Us > > Looks good. > > Looking ahead, how does this work with the proposed new build system? > Is there an automated way to check new submissions so that new features > don't undo this. > > > Acked-by: Stephen Hemminger http://mesonbuild.com/Reproducible-builds.html I'd hope if we switch build system, this shouldn't be a problem. It's definitely something to watch out for. /Bruce