From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e Date: Wed, 28 Jun 2017 20:34:41 -0700 Message-ID: <20170628203441.22e9dbb8@xeon-e3> References: <1495986280-26207-1-git-send-email-jia.guo@intel.com> <1498648044-57541-1-git-send-email-jia.guo@intel.com> <1498648044-57541-2-git-send-email-jia.guo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: helin.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org To: Jeff Guo Return-path: Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id B1D7D29CA for ; Thu, 29 Jun 2017 05:34:50 +0200 (CEST) Received: by mail-pf0-f174.google.com with SMTP id s66so43237428pfs.1 for ; Wed, 28 Jun 2017 20:34:50 -0700 (PDT) In-Reply-To: <1498648044-57541-2-git-send-email-jia.guo@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 28 Jun 2017 19:07:24 +0800 Jeff Guo wrote: > From: "Guo, Jia" > > This patch enable the hot plug feature in i40e, by monitoring the > hot plug uevent of the device. When remove event got, call the app > callback function to handle the detach process. > > Signed-off-by: Guo, Jia > --- Hot plug is good and needed. But it needs to be done in a generic fashion in the bus layer. There is nothing about uevents that are unique to i40e or even Intel devices. Plus the way hotplug is handled is OS specific, so this isn't going to work well on BSD. Sorry if I sound like a broken record but there has been a repeated pattern of Intel developers putting their head down (or in the sand) and creating functionality inside device driver.