From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] lib/librte_sched: fix update tc_credits
Date: Thu, 29 Jun 2017 10:04:04 -0700
Message-ID: <20170629100404.5fe3f5e6@xeon-e3>
References: <1498746942-1741-1-git-send-email-olivier.chirossel@gmail.com>
 <1498746942-1741-2-git-send-email-olivier.chirossel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Olivier Chirossel <olivier.chirossel@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com
 [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 79B835323
 for <dev@dpdk.org>; Thu, 29 Jun 2017 19:04:07 +0200 (CEST)
Received: by mail-pf0-f178.google.com with SMTP id e7so53523749pfk.0
 for <dev@dpdk.org>; Thu, 29 Jun 2017 10:04:07 -0700 (PDT)
In-Reply-To: <1498746942-1741-2-git-send-email-olivier.chirossel@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 29 Jun 2017 16:35:42 +0200
Olivier Chirossel <olivier.chirossel@gmail.com> wrote:

>  	/* Subport TCs */
>  	if (unlikely(port->time >= subport->tc_time)) {
> -		subport->tc_credits[0] = subport->tc_credits_per_period[0];
> -		subport->tc_credits[1] = subport->tc_credits_per_period[1];
> -		subport->tc_credits[2] = subport->tc_credits_per_period[2];
> -		subport->tc_credits[3] = subport->tc_credits_per_period[3];
> +	        for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {
> +		       if ((subport->tc_credits[j] + subport->tc_credits_per_period[j]) < subport->tc_rate[j]) {
> +	                      subport->tc_credits[j] += subport->tc_credits_per_period[j];
> +		       }
> +		       else {
> +			      subport->tc_credits[j] = subport->tc_rate[j];
> +		       }
> +		}

The loop was manually unrolled for speed.