From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: rte_ctrlmbuf_init() and CTRL_MBUF_FLAG are not used
 - shouldn't they be removed and deprecated ?
Date: Mon, 3 Jul 2017 09:42:42 +0200
Message-ID: <20170703094242.08afee17@platinum>
References: <CAGXs5wWKHqjc8Ct4fUDj0sMs=ONMRMi7iUchRF_VZDoNCWEy5A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Kevin Wilson <wkevils@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id C2E062A58
 for <dev@dpdk.org>; Mon,  3 Jul 2017 09:42:45 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id w126so159474183wme.0
 for <dev@dpdk.org>; Mon, 03 Jul 2017 00:42:45 -0700 (PDT)
In-Reply-To: <CAGXs5wWKHqjc8Ct4fUDj0sMs=ONMRMi7iUchRF_VZDoNCWEy5A@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On Mon, 3 Jul 2017 06:51:51 +0300, Kevin Wilson <wkevils@gmail.com> wrote:
> Hello,
> With the most recent master tree we have:
> 
> git grep  rte_ctrlmbuf_init
> doc/guides/prog_guide/mbuf_lib.rst:The rte_pktmbuf_init() and
> rte_ctrlmbuf_init() functions initialize some fields in the mbuf
> structure that
> lib/librte_mbuf/rte_mbuf.c:rte_ctrlmbuf_init(struct rte_mempool *mp,
> lib/librte_mbuf/rte_mbuf.h:void rte_ctrlmbuf_init(struct rte_mempool
> *mp, void *opaque_arg,
> lib/librte_mbuf/rte_mbuf_version.map:   rte_ctrlmbuf_init;
> 
> git grep  rte_is_ctrlmbuf
> lib/librte_mbuf/rte_mbuf.h:rte_is_ctrlmbuf(struct rte_mbuf *m)
> 
> git grep CTRL_MBUF_FLAG
> doc/guides/prog_guide/mbuf_lib.rst:or generic control buffers
> (indicated by the CTRL_MBUF_FLAG).
> lib/librte_mbuf/rte_mbuf.c:     m->ol_flags |= CTRL_MBUF_FLAG;
> lib/librte_mbuf/rte_mbuf.h:#define CTRL_MBUF_FLAG       (1ULL << 63)
> /**< Mbuf contains control data */
> lib/librte_mbuf/rte_mbuf.h:     return !!(m->ol_flags & CTRL_MBUF_FLAG);
> 
> rte_ctrlmbuf_init() and CTRL_MBUF_FLAG and rte_is_ctrlmbuf() are not
> used - shouldn't they be removed and deprecated ?

Yes, I'm in favor of removing it since a long time. This was
discussed and partially removed in 2014, because there was still a
user of it in examples/. But it looks that it's now unused since 2015.

Let's see if someone complains, and if no, we can plan to remove it
for 17.11.

Olivier