From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 28/33] doc: describe the new eventdev test
 application
Date: Mon, 3 Jul 2017 15:18:57 +0530
Message-ID: <20170703094856.GA29241@jerin>
References: <20170528195854.6064-1-jerin.jacob@caviumnetworks.com>
 <20170528195854.6064-29-jerin.jacob@caviumnetworks.com>
 <E923DB57A917B54B9182A2E928D00FA640C315A8@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
 "Eads, Gage" <gage.eads@intel.com>,
 "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
 "Vangati, Narender" <narender.vangati@intel.com>,
 "Rao, Nikhil" <nikhil.rao@intel.com>,
 "gprathyusha@caviumnetworks.com" <gprathyusha@caviumnetworks.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0044.outbound.protection.outlook.com [104.47.38.44])
 by dpdk.org (Postfix) with ESMTP id B3C461094
 for <dev@dpdk.org>; Mon,  3 Jul 2017 11:49:18 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA640C315A8@IRSMSX102.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 23 Jun 2017 12:53:05 +0000
> From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
>  <dev@dpdk.org>
> CC: "Richardson, Bruce" <bruce.richardson@intel.com>,
>  "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Eads, Gage"
>  <gage.eads@intel.com>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
>  "Vangati, Narender" <narender.vangati@intel.com>, "Rao, Nikhil"
>  <nikhil.rao@intel.com>, "gprathyusha@caviumnetworks.com"
>  <gprathyusha@caviumnetworks.com>, "Mcnamara, John"
>  <john.mcnamara@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 28/33] doc: describe the new eventdev test
>  application
> 
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Sunday, May 28, 2017 8:59 PM
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com; Eads, Gage <gage.eads@intel.com>;
> > nipun.gupta@nxp.com; Vangati, Narender <narender.vangati@intel.com>; Rao, Nikhil
> > <nikhil.rao@intel.com>; gprathyusha@caviumnetworks.com; Mcnamara, John
> > <john.mcnamara@intel.com>; Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH 28/33] doc: describe the new eventdev test application
> > 
> > From: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
> > 
> > Add documentation to describe usage of eventdev test application and
> > supported command line arguments.
> > 
> > CC: John McNamara <john.mcnamara@intel.com>
> > Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 
> Some comments inline below, but overall good docs;
> 
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> 
> > +
> > +* ``--plcore <n>``
> > +
> > +        Set the producer lcore id.
> 
> 
> There is --plcores (note the added "S") just below. Should standardize to one. Double check with the app - I had some issues with plcore(s) not working as expected.

OK. I will remove the --plcore and keep only --plcores

> 
> > +
> > +* ``--slcore <n>``
> > +
> > +        Set the scheduler lcore id.(Valid when eventdev is not
> > RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED capable)
> > +
> > +* ``--plcores <CORELIST>``
> > +
> > +        Set the list of cores to be used as producers.
> > +
> > +* ``--wlcores <CORELIST>``
> > +
> > +        Set the list of cores to be used as workers.
> > +
> > +* ``--stlist <type_list>``
> > +
> > +        Set the scheduled type of each stage where ``type_list`` size
> > +        determines the number of stages used in the test application.
> > +        Each type_list member can be one of the following::
> > +
> > +            P or p : Parallel schedule type
> > +            O or o : Ordered schedule type
> > +            A or a : Atomic schedule type
> > +
> > +        Application expects the ``type_list`` in comma separated form (i.e. ``--stlist
> > o,a,a,a``)
> > +
> > +* ``--nb_flows <n>``
> > +
> > +        Set the number of flows to produce.
> > +
> > +* ``--nb_packets <n>``
> > +
> > +        Set the number of packets to produce.
> 
> 
> I think "--nb_pkts" is the correct string, not "packets"?

Yes. Thanks for the review

> 
>