From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] net/virtio-user: fix crash when detaching device Date: Tue, 4 Jul 2017 17:25:17 +0800 Message-ID: <20170704092517.GO11626@yliu-home> References: <20170623124137.61091-1-allain.legacy@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: maxime.coquelin@redhat.com, dev@dpdk.org, stable@dpdk.org To: Allain Legacy Return-path: Received: from mail-pg0-f45.google.com (mail-pg0-f45.google.com [74.125.83.45]) by dpdk.org (Postfix) with ESMTP id 454842BA4 for ; Tue, 4 Jul 2017 11:25:27 +0200 (CEST) Received: by mail-pg0-f45.google.com with SMTP id j186so107568660pge.2 for ; Tue, 04 Jul 2017 02:25:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170623124137.61091-1-allain.legacy@windriver.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 23, 2017 at 08:41:37AM -0400, Allain Legacy wrote: > The rte_eth_dev.data pointer is set to a reference to a static table. > Attempting to rte_free() it leads to a panic. For example, the > following commands result in a panic if run in testpmd > > testpmd> port attach virtio_user0,path=/dev/vhost-net,iface=test0 > testpmd> port stop 2 > testpmd> port close 2 > testpmd> port detach 2 > > Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device") Note that it's prefered (and asked) to add stable tag inside the commit log. Cc: stable@dpdk.org Applied to dpdk-next-virtio, with above tag added. Thanks. --yliu