From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v7 3/4] net/mlx4: refactor RSS parent queue
	allocation
Date: Tue, 4 Jul 2017 17:20:56 +0200
Message-ID: <20170704152056.GV19852@6wind.com>
References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com>
 <3d2050ddcd58151f23ee3a0813bb174131c3c63c.1499166724.git.vasilyf@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: Vasily Philipov <vasilyf@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com
 [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id A6A7A7CD2
 for <dev@dpdk.org>; Tue,  4 Jul 2017 17:21:04 +0200 (CEST)
Received: by mail-wr0-f177.google.com with SMTP id r103so250855013wrb.0
 for <dev@dpdk.org>; Tue, 04 Jul 2017 08:21:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <3d2050ddcd58151f23ee3a0813bb174131c3c63c.1499166724.git.vasilyf@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 04, 2017 at 11:22:50AM +0000, Vasily Philipov wrote:
> A special "parent" queue must be allocated in addition to a group of
> standard Rx queues for RSS to work. This is done automatically outside of
> isolated mode by the PMD when applications request several Rx queues.
> 
> Since each configured flow rule with the RSS action may target a different
> set of queues, the PMD must have the ability to dynamically allocate
> several parent queues, one per RSS group.
> 
> If isolated mode was requested the default RSS parent queue isn't created
> in this case.
> 
> Refactor RSS parent queue allocations (currently limited to a single
> parent) in preparation for flow API RSS action support.
> 
> Signed-off-by: Vasily Philipov <vasilyf@mellanox.com>

Thanks for making the requested changes.

There is a remaining issue with this patch, creating a flow in isolated mode
causes a crash due to RX QPs not being allocated. You should temporarily
make priv_flow_create_action_queue() call rxq_create_qp() when the target QP
does not exist.

Patch looks otherwise fine.

-- 
Adrien Mazarguil
6WIND