From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: [PATCH v10 20/20] ethdev: add control interface support Date: Tue, 4 Jul 2017 17:13:37 +0100 Message-ID: <20170704161337.45926-21-ferruh.yigit@intel.com> References: <20170630165140.59594-1-ferruh.yigit@intel.com> <20170704161337.45926-1-ferruh.yigit@intel.com> Cc: Ferruh Yigit , Stephen Hemminger , Bruce Richardson , Anatoly Burakov To: dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E32057CEE for ; Tue, 4 Jul 2017 18:14:33 +0200 (CEST) In-Reply-To: <20170704161337.45926-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" To have the support corresponding kernel module (UNCI) needs to be inserted. If kernel module is not there, application will run as it is without kernel control path support. When UNCI module inserted, running application creates a virtual Linux network interface (dpdk$) per DPDK port. This interface can be used by traditional Linux tools. If Userspace Network Control Interface (UNCI) kernel module (rte_unci.ko) inserted, virtual interfaces created for each DPDK port for control purposes. Created interfaces are named as dpdk#, like: $ ifconfig dpdk0; ifconfig dpdk1 dpdk0: flags=4099 mtu 1500 ether 90:e2:ba:0e:49:b9 txqueuelen 1000 (Ethernet) RX packets 0 bytes 0 (0.0 B) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 0 bytes 0 (0.0 B) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 dpdk1: flags=4099 mtu 1500 ether 00:1b:21:76:fa:21 txqueuelen 1000 (Ethernet) RX packets 0 bytes 0 (0.0 B) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 0 bytes 0 (0.0 B) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 Regular Linux commands can be issued on interfaces: $ ethtool -i dpdk0 driver: net_ixgbe version: DPDK 17.08.0-rc0 firmware-version: 0x61bf0001 expansion-rom-version: bus-info: 0000:08:00.1 supports-statistics: no supports-test: no supports-eeprom-access: yes supports-register-dump: yes supports-priv-flags: no Signed-off-by: Ferruh Yigit --- v9: * fix shared build --- drivers/net/Makefile | 4 ++++ lib/librte_ether/rte_ethdev_pci.h | 15 ++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/net/Makefile b/drivers/net/Makefile index 35ed8135a..cdabc2349 100644 --- a/drivers/net/Makefile +++ b/drivers/net/Makefile @@ -39,6 +39,10 @@ endif core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether core-libs += librte_net librte_kvargs +ifeq ($(CONFIG_RTE_LIBRTE_CTRL_IF),y) +core-libs += librte_ctrl_if +endif + DIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += af_packet DEPDIRS-af_packet = $(core-libs) DIRS-$(CONFIG_RTE_LIBRTE_ARK_PMD) += ark diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ether/rte_ethdev_pci.h index 69aab03fb..fcdee9229 100644 --- a/lib/librte_ether/rte_ethdev_pci.h +++ b/lib/librte_ether/rte_ethdev_pci.h @@ -38,6 +38,13 @@ #include #include +#ifdef RTE_LIBRTE_CTRL_IF +#include +#else +#define rte_eth_control_interface_create(port_id) do { } while (0) +#define rte_eth_control_interface_destroy(port_id) do { } while (0) +#endif + /** * Copy pci device info to the Ethernet device data. * @@ -157,8 +164,12 @@ rte_eth_dev_pci_generic_probe(struct rte_pci_device *pci_dev, RTE_FUNC_PTR_OR_ERR_RET(*dev_init, -EINVAL); ret = dev_init(eth_dev); - if (ret) + if (ret) { rte_eth_dev_pci_release(eth_dev); + return ret; + } + + rte_eth_control_interface_create(eth_dev->data->port_id); return ret; } @@ -179,6 +190,8 @@ rte_eth_dev_pci_generic_remove(struct rte_pci_device *pci_dev, if (!eth_dev) return -ENODEV; + rte_eth_control_interface_destroy(eth_dev->data->port_id); + if (dev_uninit) { ret = dev_uninit(eth_dev); if (ret) -- 2.13.0