From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v7 6/6] devargs: parse bus info
Date: Wed, 5 Jul 2017 11:03:48 -0700
Message-ID: <20170705110348.08a9ce7a@xeon-e3>
References: <cover.1499127915.git.gaetan.rivet@6wind.com>
 <cover.1499211317.git.gaetan.rivet@6wind.com>
 <cd5734d73c2a4908523b88ae5e04b7eec4aa9928.1499211317.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com
 [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id 0CCB61C0B
 for <dev@dpdk.org>; Wed,  5 Jul 2017 20:03:55 +0200 (CEST)
Received: by mail-pf0-f181.google.com with SMTP id c73so133338540pfk.2
 for <dev@dpdk.org>; Wed, 05 Jul 2017 11:03:55 -0700 (PDT)
In-Reply-To: <cd5734d73c2a4908523b88ae5e04b7eec4aa9928.1499211317.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed,  5 Jul 2017 01:55:23 +0200
Gaetan Rivet <gaetan.rivet@6wind.com> wrote:

>  	case RTE_DEVTYPE_WHITELISTED_PCI:
>  	case RTE_DEVTYPE_BLACKLISTED_PCI:
>  		/* try to parse pci identifier */
> -		if (eal_parse_pci_BDF(buf, &devargs->pci.addr) != 0 &&
> -		    eal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0)
> +		if (bus->parse(devname, &devargs->pci.addr) != 0)
>  			goto fail;

Shouldn't these go under bus args for PCI?
It would be good to get all the bus specific args out of generic code.