From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v5 1/3] examples/eventdev_pipeline: added
	sample app
Date: Thu, 6 Jul 2017 19:08:14 +0530
Message-ID: <20170706133813.GA26214@jerin>
References: <1498751388-41571-2-git-send-email-david.hunt@intel.com>
 <1498830673-56759-1-git-send-email-david.hunt@intel.com>
 <1498830673-56759-2-git-send-email-david.hunt@intel.com>
 <20170703035755.GA6275@jerin>
 <25452a77-c5ae-97e8-b41a-5dfcb9fb19a6@intel.com>
 <20170705052853.GA8031@jerin>
 <dc8aa64b-a5ad-f52a-1173-0be9a5af8ccb@intel.com>
 <20170706033120.GA10973@jerin>
 <7987361f-935e-a689-103d-276fe3a4c36e@intel.com>
 <e30dabc4-b057-6274-71f9-5a820398b70e@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, harry.van.haaren@intel.com, Gage Eads <gage.eads@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>
To: "Hunt, David" <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0048.outbound.protection.outlook.com [104.47.32.48])
 by dpdk.org (Postfix) with ESMTP id 4B7BB1094
 for <dev@dpdk.org>; Thu,  6 Jul 2017 15:38:46 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <e30dabc4-b057-6274-71f9-5a820398b70e@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Thu, 6 Jul 2017 14:26:47 +0100
> From: "Hunt, David" <david.hunt@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: dev@dpdk.org, harry.van.haaren@intel.com, Gage Eads
>  <gage.eads@intel.com>, Bruce Richardson <bruce.richardson@intel.com>
> Subject: Re: [PATCH v5 1/3] examples/eventdev_pipeline: added sample app
> User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
>  Thunderbird/45.8.0
> 
> Hi Jerin,
> 
> On 6/7/2017 11:04 AM, Hunt, David wrote:
> > 
> > On 6/7/2017 4:31 AM, Jerin Jacob wrote:
> 
> Having looked at this a bit more, and unable to reproduce with my original
> kernel version checkpatch, and the patchwork version does not show, and the
> 4.11.9 stable kernel version does not show, I suggest we mark these down as
> false positives, as the string is not intended to show the function name.
> 
> 
> > > I will give pull request Thomas on Friday morning. I will include
> > > this change set
> > > in the pull request.
> > > 
> > > Regarding the performance drop, Can you add __rte_cache_aligned on those
> > > variable which creates regression in moving to rte_malloc area. The
> > > cache line could be shared? If not fixing then its fine we will look
> > > into that latter.
> > 
> > I will investigate and post a new patch in a few hours.
> > 
> 
> Of the 4 variables I am attempting to move into fastpath structure, no
> matter whether I move them one at a time or all at once, with
> __rte_cache_align or not, I still see a significant performance degradation.
> I suggest looking into this later.
> 
> I will push a patch in the next couple of hours with the first two changes
> mentioned above.  OK with you?


OK.


> 
> Regards,
> Dave.
> 
> 
> 
>