From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yliu@fridaylinux.org>
Subject: Re: [PATCH v2] examples/vhost: introduce a new
 vhost-user-scsi sample application
Date: Fri, 7 Jul 2017 12:48:54 +0800
Message-ID: <20170707044854.GV11626@yliu-home>
References: <1498728512-12728-1-git-send-email-changpeng.liu@intel.com>
 <1499487291-17053-1-git-send-email-changpeng.liu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Changpeng Liu <changpeng.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com
 [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 221D72BFF
 for <dev@dpdk.org>; Fri,  7 Jul 2017 06:49:03 +0200 (CEST)
Received: by mail-pf0-f193.google.com with SMTP id z6so2978846pfk.3
 for <dev@dpdk.org>; Thu, 06 Jul 2017 21:49:03 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1499487291-17053-1-git-send-email-changpeng.liu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Jul 08, 2017 at 12:14:51PM +0800, Changpeng Liu wrote:
> +.. note::
> +    You must check whether your Qemu can support "vhost-user-scsi" or not,
> +    Qemu v2.9.50 or newer version is required.

QEMU v2.9.50 looks like a stable version, and I don't think they will
backport new features on it (or, do they?).

So, it should be "v2.10" here?

> +		switch (pc) {
> +		case SPC_VPD_SUPPORTED_VPD_PAGES:
> +			hlen = 4;
> +			vpage->params[0] = SPC_VPD_SUPPORTED_VPD_PAGES;
> +			vpage->params[1] = SPC_VPD_UNIT_SERIAL_NUMBER;
> +			vpage->params[2] = SPC_VPD_DEVICE_IDENTIFICATION;
> +			len = 3;
> +			/* PAGE LENGTH */
> +			to_be16(vpage->alloc_len, len);
> +		break;

You didn't resolve my previous comment regarding the "break"
indentation issue.

Otherwise, this patch looks good to me.

	--yliu