From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v8 6/6] devargs: parse bus info
Date: Fri, 7 Jul 2017 10:31:35 +0200
Message-ID: <20170707083135.GP11154@bidouze.vm.6wind.com>
References: <cover.1499211317.git.gaetan.rivet@6wind.com>
 <cover.1499384335.git.gaetan.rivet@6wind.com>
 <c1b0948b7fa37cf71fadf44365f13a52264557c8.1499384335.git.gaetan.rivet@6wind.com>
 <20170706174502.0eaa5d0c@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com
 [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 339ED2C2B
 for <dev@dpdk.org>; Fri,  7 Jul 2017 10:31:44 +0200 (CEST)
Received: by mail-wr0-f179.google.com with SMTP id c11so36448368wrc.3
 for <dev@dpdk.org>; Fri, 07 Jul 2017 01:31:44 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20170706174502.0eaa5d0c@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 06, 2017 at 05:45:02PM -0700, Stephen Hemminger wrote:
> On Fri,  7 Jul 2017 02:03:12 +0200
> Gaetan Rivet <gaetan.rivet@6wind.com> wrote:
> 
> > +static int
> > +bus_name_cmp(const struct rte_bus *bus, const void *_name)
> > +{
> > +	const char *name = _name;
> > +
> > +	return strncmp(bus->name, name,
> > +		       strlen(bus->name));
> 
> I don't think you need the _name variable hack. C will cast the argument to strncmp

You're right, and it was just habit. Usually I prefer giving a type to a
generic parameter, but in this case it may be too trivial.

-- 
Gaëtan Rivet
6WIND