From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 2/2] examples: adjust Rx and Tx descriptors
 to device limits
Date: Sat, 8 Jul 2017 10:05:37 -0700
Message-ID: <20170708100537.7a52d067@xeon-e3>
References: <1488459935-13273-2-git-send-email-arybchenko@solarflare.com>
 <1495727874-10892-1-git-send-email-arybchenko@solarflare.com>
 <1495727874-10892-2-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, Sergio Gonzalez Monroy
 <sergio.gonzalez.monroy@intel.com>, Remy Horton <remy.horton@intel.com>,
 Jianfeng Tan <jianfeng.tan@intel.com>, Declan Doherty
 <declan.doherty@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Yuanhan
 Liu <yuanhan.liu@linux.intel.com>, Maxime Coquelin
 <maxime.coquelin@redhat.com>, Konstantin Ananyev
 <konstantin.ananyev@intel.com>, Bruce Richardson
 <bruce.richardson@intel.com>, Reshma Pattan <reshma.pattan@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Byron Marohn
 <byron.marohn@intel.com>, Pablo de Lara Guarch
 <pablo.de.lara.guarch@intel.com>, Pawel Wodkowski
 <pawelx.wodkowski@intel.com>, Tomasz Kantecki <tomasz.kantecki@intel.com>,
 John McNamara <john.mcnamara@intel.com>, Daniel Mrzyglod
 <danielx.t.mrzyglod@intel.com>, Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46])
 by dpdk.org (Postfix) with ESMTP id 48EE116E
 for <dev@dpdk.org>; Sat,  8 Jul 2017 19:05:45 +0200 (CEST)
Received: by mail-pg0-f46.google.com with SMTP id k14so30824623pgr.0
 for <dev@dpdk.org>; Sat, 08 Jul 2017 10:05:45 -0700 (PDT)
In-Reply-To: <1495727874-10892-2-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 25 May 2017 16:57:54 +0100
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> +	retval = rte_eth_dev_adjust_nb_rx_tx_desc(portid, &nb_rxd, &nb_txd);
> +	if (retval != 0)
> +		rte_exit(EXIT_FAILURE, "port %u: rte_eth_dev_adjust_nb_rx_tx_desc "
> +				"failed (res=%d)\n", portid, retval);
> +

rte_exit is equivalent to panic in kernel.
No API call should call rte_exit. Instead the error must be propogated
back to caller and/or leave the slave in a dead state.