From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH 1/2] eal: internalize devargs parsing
Date: Sun, 9 Jul 2017 13:23:12 +0200
Message-ID: <20170709112312.GS11154@bidouze.vm.6wind.com>
References: <20170709092847.13339-1-jblunck@infradead.org>
 <20170709092847.13339-2-jblunck@infradead.org>
 <12210751.V8za9RMinW@xps>
 <CALe+Z00j4X6+5Ay9XMqn-_sjy028q_tHues9DC3qFmSU42crmg@mail.gmail.com>
 <CALe+Z03dJ0KDmYS=3VorQg-ORxTVdA9zE_Dp6fC-+NkbT9Ao6Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>
To: Jan Blunck <jblunck@infradead.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com
 [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 1BFB058CE
 for <dev@dpdk.org>; Sun,  9 Jul 2017 13:23:21 +0200 (CEST)
Received: by mail-wr0-f180.google.com with SMTP id r103so102559158wrb.0
 for <dev@dpdk.org>; Sun, 09 Jul 2017 04:23:21 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CALe+Z03dJ0KDmYS=3VorQg-ORxTVdA9zE_Dp6fC-+NkbT9Ao6Q@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Jul 09, 2017 at 06:56:25AM -0400, Jan Blunck wrote:
> On Sun, Jul 9, 2017 at 6:46 AM, Jan Blunck <jblunck@infradead.org> wrote:
> > On Sun, Jul 9, 2017 at 6:28 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> >> 09/07/2017 11:28, Jan Blunck:
> >>> This is going to get cleaned up in future releases so lets not expose
> >>> this API unnecessarily.
> >>>
> >>> Signed-off-by: Jan Blunck <jblunck@infradead.org>
> >>> ---
> >>> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> >>> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> >>> @@ -211,7 +211,6 @@ DPDK_17.08 {
> >>>  EXPERIMENTAL {
> >>>       global:
> >>>
> >>> -     rte_eal_devargs_parse;
> >>>       rte_eal_hotplug_add;
> >>>       rte_eal_hotplug_remove;
> >>
> >> We need to expose it temporarily as experimental in order to let
> >> the failsafe driver calling it.
> >> When reworked in 17.11, this function or an equivalent should allow
> >> failsafe (and maybe bonding) to parse slave declaration.
> >
> > There is no need for the failsafe PMD to parse it to a rte_devargs
> > because it can just pass the string to the hotplug API.
> 
> Just in case it isn't clear enough: the failsafe PMD is using the
> rte_devargs structure to get the bus name. The bus name is explicitly
> given in the hotplug API. There is really no need to deal with
> rte_devargs here.

The fail-safe PMD uses the rte_devargs parsing helper to find the
bus name from a device argument handled to it.

As you point out, the bus name is explicitly given in the hotplug API.
In order to be able to explicitly give the bus name, the caller has to
know it. This is done by parsing devargs and using the result.

-- 
Gaëtan Rivet
6WIND