From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH v2 6/8] mbuf: use 2 bytes for port and nb segments Date: Mon, 10 Jul 2017 10:00:18 +0200 Message-ID: <20170710100018.403b82ec@platinum> References: <1488966121-22853-1-git-send-email-olivier.matz@6wind.com> <20170404162807.20157-1-olivier.matz@6wind.com> <20170404162807.20157-7-olivier.matz@6wind.com> <20170406054523.GP18844@yliu-dev.sh.intel.com> <20170418150304.58d2c4a1@glumotte.dev.6wind.com> <8F6C2BD409508844A0EFC19955BE0941512B02B2@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Yuanhan Liu , "dev@dpdk.org" , "Ananyev, Konstantin" , "Richardson, Bruce" , "mb@smartsharesystems.com" , "Chilikin, Andrey" , "jblunck@infradead.org" , "nelio.laranjeiro@6wind.com" , "arybchenko@solarflare.com" , "thomas.monjalon@6wind.com" , "jerin.jacob@caviumnetworks.com" To: "Wang, Zhihong" Return-path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id B7EF27CBE for ; Mon, 10 Jul 2017 10:00:21 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id k67so126863373wrc.2 for ; Mon, 10 Jul 2017 01:00:21 -0700 (PDT) In-Reply-To: <8F6C2BD409508844A0EFC19955BE0941512B02B2@SHSMSX103.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On Tue, 4 Jul 2017 07:54:23 +0000, "Wang, Zhihong" wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier MATZ > > Sent: Tuesday, April 18, 2017 9:03 PM > > To: Yuanhan Liu > > Cc: dev@dpdk.org; Ananyev, Konstantin ; > > Richardson, Bruce ; > > mb@smartsharesystems.com; Chilikin, Andrey ; > > jblunck@infradead.org; nelio.laranjeiro@6wind.com; > > arybchenko@solarflare.com; thomas.monjalon@6wind.com; > > jerin.jacob@caviumnetworks.com > > Subject: Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb > > segments > > > > Hi Yuanhan, > > > > On Thu, 6 Apr 2017 13:45:23 +0800, Yuanhan Liu > > wrote: > > > Hi Olivier, > > > > > > On Tue, Apr 04, 2017 at 06:28:05PM +0200, Olivier Matz wrote: > > > > Change the size of m->port and m->nb_segs to 16 bits. > > > > > > But all the ethdev APIs are still using 8 bits. 16 bits won't really > > > take effect without updating those APIs. Any plans? > > > > > > --yliu > > > > Yes, there is some work in ethdev, drivers and in example apps to > > make the change effective. I think we could define a specific type for > > a port number, maybe rte_eth_port_num_t. Using this type could be a > > first step (for 17.08) before switching to 16 bits (17.11?). > > > > I'll do the change and send a rfc. > > Ping ;) Is this still in your plan? > Sorry, I don't think I will have time to work on this issue in the coming weeks. If you plan to do it, I will be happy to help with reviews and comments. As I said in a previous message, I think a good first step would be to introduce a typedef for the port number: rte_eth_port_num_t. It can still be uint8_t for now, and can be switched to 16 bits in one step when everyone uses this new type. Olivier