From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] lib/rib: Add Routing Information Base library
Date: Tue, 11 Jul 2017 13:28:07 -0700
Message-ID: <20170711132807.4cbceb72@xeon-e3>
References: <1499801585-10031-1-git-send-email-medvedkinv@gmail.com>
 <1499801585-10031-2-git-send-email-medvedkinv@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Medvedkin Vladimir <medvedkinv@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46])
 by dpdk.org (Postfix) with ESMTP id A6045374C
 for <dev@dpdk.org>; Tue, 11 Jul 2017 22:28:14 +0200 (CEST)
Received: by mail-pg0-f46.google.com with SMTP id t186so1574299pgb.1
 for <dev@dpdk.org>; Tue, 11 Jul 2017 13:28:14 -0700 (PDT)
In-Reply-To: <1499801585-10031-2-git-send-email-medvedkinv@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 11 Jul 2017 19:33:05 +0000
Medvedkin Vladimir <medvedkinv@gmail.com> wrote:

> +
> +#define ROUNDUP(x, y)   ((((x - 1) >> (32 - y)) + 1) << (32 - y))

There is already RTE_ALIGN_FLOOR/RTE_ALIGN_CEIL


> +#define RTE_DIR24_8_GET_TBL24_P(fib, ip)			\
> +	((void *)&((uint8_t *)fib->tbl24)[(ip &			\
> +		RTE_DIR24_8_TBL24_MASK) >> (8 - fib->nh_sz)])	\
> +

Why is this a macro and not an inline function.
The expresion could also be split up to be simpler, and compiler
would generate same result.