From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v8 03/11] net/failsafe: add fail-safe PMD
Date: Tue, 11 Jul 2017 23:48:19 +0200
Message-ID: <20170711214819.GZ11154@bidouze.vm.6wind.com>
References: <cover.1499564333.git.gaetan.rivet@6wind.com>
 <cover.1499728587.git.gaetan.rivet@6wind.com>
 <f1e9f9e386c72caecb1019daca5e0f35f3bf0265.1499728587.git.gaetan.rivet@6wind.com>
 <6696281.voRgjYsRM1@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com
 [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 2DFB62E8B
 for <dev@dpdk.org>; Tue, 11 Jul 2017 23:48:29 +0200 (CEST)
Received: by mail-wr0-f170.google.com with SMTP id c11so7317212wrc.3
 for <dev@dpdk.org>; Tue, 11 Jul 2017 14:48:29 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <6696281.voRgjYsRM1@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote:
> 11/07/2017 01:19, Gaetan Rivet:
> > --- /dev/null
> > +++ b/drivers/net/failsafe/failsafe_args.c
> [...]
> > +#include <errno.h>
> 
> Do you really need errno in this file?

It's used for error handling on strtoull and popen.
Why, is it a problem to include errno.h?

-- 
Gaëtan Rivet
6WIND