From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v8 03/11] net/failsafe: add fail-safe PMD
Date: Wed, 12 Jul 2017 00:25:49 +0200
Message-ID: <20170711222549.GA11154@bidouze.vm.6wind.com>
References: <cover.1499564333.git.gaetan.rivet@6wind.com>
 <6696281.voRgjYsRM1@xps>
 <20170711214819.GZ11154@bidouze.vm.6wind.com>
 <83323603.jg1xmzcquq@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com
 [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id E3DA9376C
 for <dev@dpdk.org>; Wed, 12 Jul 2017 00:25:59 +0200 (CEST)
Received: by mail-wr0-f174.google.com with SMTP id r103so8500728wrb.0
 for <dev@dpdk.org>; Tue, 11 Jul 2017 15:25:59 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <83323603.jg1xmzcquq@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jul 12, 2017 at 12:21:24AM +0200, Thomas Monjalon wrote:
> 11/07/2017 23:48, Gaëtan Rivet:
> > On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote:
> > > 11/07/2017 01:19, Gaetan Rivet:
> > > > --- /dev/null
> > > > +++ b/drivers/net/failsafe/failsafe_args.c
> > > [...]
> > > > +#include <errno.h>
> > > 
> > > Do you really need errno in this file?
> > 
> > It's used for error handling on strtoull and popen.
> > Why, is it a problem to include errno.h?
> 
> I don't see errno used in this patch.
> I think it is used in next patches.

Ah, yes, you're right, sorry.
Will fix, thanks.

-- 
Gaëtan Rivet
6WIND