From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v5 1/7] service cores: header and implementation Date: Wed, 12 Jul 2017 22:05:23 +0530 Message-ID: <20170712163521.GB2860@jerin> References: <1499445667-32588-1-git-send-email-harry.van.haaren@intel.com> <1499782773-12277-1-git-send-email-harry.van.haaren@intel.com> <1499782773-12277-2-git-send-email-harry.van.haaren@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, thomas@monjalon.net, keith.wiles@intel.com, bruce.richardson@intel.com To: Harry van Haaren Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0083.outbound.protection.outlook.com [104.47.41.83]) by dpdk.org (Postfix) with ESMTP id CF5F02BF5 for ; Wed, 12 Jul 2017 18:35:51 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1499782773-12277-2-git-send-email-harry.van.haaren@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Tue, 11 Jul 2017 15:19:27 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, > keith.wiles@intel.com, bruce.richardson@intel.com, Harry van Haaren > > Subject: [PATCH v5 1/7] service cores: header and implementation > X-Mailer: git-send-email 2.7.4 > > Add header files, update .map files with new service > functions, and add the service header to the doxygen > for building. > > This service header API allows DPDK to use services as > a concept of something that requires CPU cycles. An example > is a PMD that runs in software to schedule events, where a > hardware version exists that does not require a CPU. > > Signed-off-by: Harry van Haaren Looks good to me. Acked-by: Jerin Jacob > > --- > > v5: > - Improved service_set_stats_enable() to operate per service (Jerin) > - Fixed un-documented doxygen parameter (Jerin) > - Renamed cores_state to lcore_states (Jerin) > - Optimized atomic operations and flags (Jerin) > - Removed info about RFCs etc from commit message (Jerin) > - Add lcore_count check to default setup function and return early (Jerin) > - Add memory barriers to lcore_add() and lcore_del() (Jerin) > - Rename start function to rte_service_start_with_defaults() (Jerin) > - Rename header to rte_service_component.h (Jerin/Thomas) > > v4: > - Fixed (unsigned) checkpatch error > - Fixed misleading-indentation/if { } brackets (checkpatch/Jerin) > - Fixed set function argument to be "enable" instead of "enabled" (Jerin) > - Improve doxygen comment for size of array in rte_service_core_list (Jerin) > - Fixed typos (Jerin) > - Optimized atomic clear after running service (Jerin) > - Added smp_rmb() at end of loop to re-load runstate / mapping (Jerin) > - Fix issue with lcore role not being adhered to (Jerin) > - Add experimental warnings for all service core functions (Thomas) > - Moved service core functions into EXPERIMENTAL section of .map (Thomas) > - Improve documentation of rte_service_lcore_reset_all() (Harry) > > v3: > - None. > > v2: > Thanks Jerin for review - below a list your suggested changes; > - Doxygen rename to "service cores" for consistency > - use lcore instead of core for function names > - Fix about 10 typos / seplling msitakse ;) > - Dix doxygen /** comments for functions > - Doxygen @param[out] improvements > - int8_t for socket_id to ordinary int > - Rename MACROS for readability > - Align structs to cache lines > - Allocate fastpath-used data from hugepages > - Added/fixed memory barriers for multi-core scheduling > - Add const to variables, and hoist above loop > - Optimize cmpset atomic if MT_SAFE or only one core mapped > - Statistics collection only when requested > - Add error check for array pointer > - Remove panic() calls from library > - Fix TODO notes from previous patchset > > There are also some other changes; > - Checkpatch issues fixed > - .map file updates > - Add rte_service_get_by_name() function