From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH 07/13] devargs: add busname string field Date: Thu, 13 Jul 2017 15:17:12 +0200 Message-ID: <20170713131712.GJ11154@bidouze.vm.6wind.com> References: <20170711232512.54641-1-jblunck@infradead.org> <20170711232512.54641-8-jblunck@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Jan Blunck Return-path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 8C93D29D9 for ; Thu, 13 Jul 2017 15:17:22 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id r103so52995863wrb.0 for ; Thu, 13 Jul 2017 06:17:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170711232512.54641-8-jblunck@infradead.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 11, 2017 at 07:25:06PM -0400, Jan Blunck wrote: > This adds the busname as a string to struct rte_devargs. The function > rte_eal_devargs_add() is adding the busname based on the devtype which > is ok for now since the function is deprecated anyway. > > As a side-effect this is also no longer validating the PCI device name. > This was done only for PCI devices anyway but didn't guarantee that this > device exists. > Why add the bus name as a string instead of using the bus handle already present within the rte_devargs? I don't understand the need for this commit, can you explain the problem you are solving? -- Gaëtan Rivet 6WIND