From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH 04/13] pci: use scan_mode configuration Date: Thu, 13 Jul 2017 19:59:00 +0200 Message-ID: <20170713175900.GL11154@bidouze.vm.6wind.com> References: <20170711232512.54641-1-jblunck@infradead.org> <20170711232512.54641-5-jblunck@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Jan Blunck Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id A9B49271 for ; Thu, 13 Jul 2017 19:59:10 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id w126so213802wme.0 for ; Thu, 13 Jul 2017 10:59:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170711232512.54641-5-jblunck@infradead.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 11, 2017 at 07:25:03PM -0400, Jan Blunck wrote: > When scanning/probing devices the bus should use its configuration instead > of looking at the devargs->type field. > With this patch, how do you probe a device that was previously blacklisted? The answers I see to this question are pretty bad, maybe you have a good solution. On the other hand, can you explain why you want this limitation? What problem does this solve? You have one view of the hotplug API, I would like to understand why you hold this view. Regarding the rte_devargs API, it can be fixed without making the hotplug needlessly complicated I think. I must point out that the scan_mode (incorrectly named) is something that will be removed next release. The probe policies will be reworked and I don't think that the solution should be proposed as a fix a few days before the RC2. > Signed-off-by: Jan Blunck > --- > lib/librte_eal/common/eal_common_pci.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c > index 72fcc35c2..fb0e29ac4 100644 > --- a/lib/librte_eal/common/eal_common_pci.c > +++ b/lib/librte_eal/common/eal_common_pci.c > @@ -197,8 +197,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, > > /* no initialization when blacklisted, return without error */ > if (dev->device.devargs != NULL && > - dev->device.devargs->type == > - RTE_DEVTYPE_BLACKLISTED_PCI) { > + rte_pci_bus.bus.conf.scan_mode == RTE_BUS_SCAN_BLACKLIST) { > RTE_LOG(INFO, EAL, " Device is blacklisted, not" > " initializing\n"); > return 1; > @@ -404,8 +403,7 @@ rte_pci_probe(void) > /* probe all or only whitelisted devices */ > if (probe_all) > ret = pci_probe_all_drivers(dev); > - else if (devargs != NULL && > - devargs->type == RTE_DEVTYPE_WHITELISTED_PCI) > + else if (devargs != NULL) > ret = pci_probe_all_drivers(dev); > if (ret < 0) { > RTE_LOG(ERR, EAL, "Requested device " PCI_PRI_FMT > -- > 2.13.2 > -- Gaëtan Rivet 6WIND