From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC 09/14] sfc: use new rte_eth_link helpers
Date: Mon, 17 Jul 2017 09:02:29 -0700
Message-ID: <20170717090229.48abee36@xeon-e3>
References: <20170714183027.16021-1-stephen@networkplumber.org>
 <20170714183027.16021-10-stephen@networkplumber.org>
 <60caca67-cfb9-c474-7fa9-faa7752fdaf1@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com
 [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id D598D47CD
 for <dev@dpdk.org>; Mon, 17 Jul 2017 18:02:32 +0200 (CEST)
Received: by mail-pf0-f172.google.com with SMTP id q86so78529014pfl.3
 for <dev@dpdk.org>; Mon, 17 Jul 2017 09:02:32 -0700 (PDT)
In-Reply-To: <60caca67-cfb9-c474-7fa9-faa7752fdaf1@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, 16 Jul 2017 16:48:50 +0300
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> On 07/14/2017 09:30 PM, Stephen Hemminger wrote:
> > Use the new API (_rte_eth_link_update) to handle link status update.
> > ALso fixes a bug where this driver was not returning -1 when link status changed.  
> 
> It is really good that you raise it, since:
>   -  as far as I can see the return value of the link_update is never used
>   - return value is not described and it is unclear what is meant by "link
>      status changed" since initial point is unspecified
> 
> We have interpreted link status change as change in data->dev_link
> made in the current execution flow, but not in parallel execution flow.

All drivers must do the same thing. Private interpretation is not good.