From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v2] crypto/dpaa2_sec: fix the return of supported API Date: Tue, 18 Jul 2017 22:39:07 +0800 Message-ID: <20170718143907.GV11626@yliu-home> References: <20170718073356.14288-1-akhil.goyal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Akhil Goyal , "dev@dpdk.org" , "stable@dpdk.org" , "hemant.agrawal@nxp.com" To: "De Lara Guarch, Pablo" Return-path: Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id D3685376C for ; Tue, 18 Jul 2017 16:39:16 +0200 (CEST) Received: by mail-pf0-f181.google.com with SMTP id s70so3388951pfs.0 for ; Tue, 18 Jul 2017 07:39:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 18, 2017 at 10:26:39AM +0000, De Lara Guarch, Pablo wrote: > Hi Akhil, > > > -----Original Message----- > > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > > Sent: Tuesday, July 18, 2017 8:34 AM > > To: dev@dpdk.org; stable@dpdk.org > > Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo > > ; yliu@fridaylinux.org; Akhil Goyal > > > > Subject: [PATCH v2] crypto/dpaa2_sec: fix the return of supported API > > > > call to dpaa2_sec_dev_configure() is made mandatory, but dpaa2_sec_pmd > > returns a ENOTSUP which results in device not getting configured. > > > > dpaa2_sec PMD does not need any further configuration to be done in > > dpaa2_sec_dev_configure, hence returning 0 > > > > Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations") > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Akhil Goyal > > Looks ok to me, but this is only applicable in the stable branch, > so no need to send it to dev@dpdk.org. Why? We already have such fix in upstream? Normally, we just pick upstream commits (but not patches: the emails) to stable release. --yliu