From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Freimann Subject: Re: [PATCH] all: refactor coding style Date: Thu, 20 Jul 2017 09:56:01 +0200 Message-ID: <20170720075601.cbuizcbke5svgsos@dhcp-192-218.str.redhat.com> References: <1500455196-182365-1-git-send-email-tiwei.bie@intel.com> <20170719102321.GA6991@debian-ZGViaWFuCg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: "Van Haaren, Harry" , "thomas@monjalon.net" , "dev@dpdk.org" To: Tiwei Bie Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id DF0742C50 for ; Thu, 20 Jul 2017 09:56:05 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170719102321.GA6991@debian-ZGViaWFuCg> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 19, 2017 at 06:23:21PM +0800, Tiwei Bie wrote: >On Wed, Jul 19, 2017 at 05:24:38PM +0800, Van Haaren, Harry wrote: [...] >> Hi Tiwei, >> >> Although the idea and motivation for code-cleanup are good, performing >> large cleanup across a code-base is not a good solution. The reason that >> these types of cleanups (or even re-formatting the entire codebase) are not >> performed often is that it "invalidates" any currently-in-progress patch-sets. >> As a result, more work is required from many contributors to rebase useful >> features due to across-the-board white-space cleanups. >> >> Just expressing concern that we need to think carefully about the impacts >> of such a patch. >> > >Yeah, I agree. Such patch may cause many conflicts. But this patch >is almost generated automatically, that is to say, it's a quick work. >And it's more like some fixes (for the bad coding style) rather than >silly re-formatting done by `indent'. So I just want to share it with >the community, and see the potential feedbacks. Thank you for your >comments! :) what I'm more concerned about with these kind of huge clean-ups is that it makes git-blame less useful for me. Next time I want to look up who changed this line I'll just find your cleanup patch. Then I have to do another step to find out which commit introduced the change I'm looking for. I'm more for cleaning up these things next time you do a semantic change in this code. regards, Jens