From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH 0/2] fix flow rules copy functions Date: Mon, 24 Jul 2017 11:00:38 +0200 Message-ID: <20170724090038.GU19852@6wind.com> References: <1500880222-13347-1-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jingjing Wu , dev@dpdk.org, Gaetan Rivet To: Matan Azrad Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 6B04A47CD for ; Mon, 24 Jul 2017 11:00:47 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id m85so11504333wma.1 for ; Mon, 24 Jul 2017 02:00:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1500880222-13347-1-git-send-email-matan@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 24, 2017 at 10:10:20AM +0300, Matan Azrad wrote: > some issue seen when trying to test failsafe plug out and in. > > Matan Azrad (2): > app/testpmd: fix flow rule copy functions > ethdev: fix flow rule copy functions > > app/test-pmd/config.c | 16 ++++++++++------ > lib/librte_ether/rte_flow.c | 16 ++++++++++------ > 2 files changed, 20 insertions(+), 12 deletions(-) Thanks! I think the original code didn't have these functions and used the flow_item[x].size value directly, which worked fine until I added support for the RAW item and the RSS action. Both had to be handled through special functions which I messed up. Unfortunately I didn't catch it in testpmd because it doesn't do anything with the copied data unlike the fail-safe PMD. Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND