From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] doc: add author on cc to git fixline alias Date: Mon, 24 Jul 2017 17:07:03 +0200 Message-ID: <20170724150703.GD19852@6wind.com> References: <1499866732-17085-1-git-send-email-harry.van.haaren@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, thomas@monjalon.net To: Harry van Haaren Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 71DB81F5 for ; Mon, 24 Jul 2017 17:07:12 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id m85so20087256wma.1 for ; Mon, 24 Jul 2017 08:07:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1499866732-17085-1-git-send-email-harry.van.haaren@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 12, 2017 at 02:38:52PM +0100, Harry van Haaren wrote: > With this commit, the correct method to use git fixline to indicate > a fix of a previous commit has changed. The new rules require the > author of the original code that is being fixed to be on CC. > > The logic behind this improvement is that if there is a genuine bug, > one of the ideal people to review is the author of the original code > being fixed. Adding them on Cc makes them aware of the patch, avoiding > it from being passed by accidentally while reading the mailing-list. > > Given that the original author (now on Cc:) might not actually review, > there is no value in keeping the Cc: in git commit history. If the > original author performs a review, their Reviewed-by: or Acked-by: is > stored in git history (same as now). > > Signed-off-by: Harry van Haaren Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND