From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] net/virtio: fix MAC addr not correct read Date: Mon, 31 Jul 2017 10:31:03 +0800 Message-ID: <20170731023103.GB9612@yliu-home> References: <1501282874-127700-1-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, stable@dpdk.org, Zhihong Wang , Maxime Coquelin To: Jianfeng Tan Return-path: Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 8AD8E99C9 for ; Mon, 31 Jul 2017 04:31:10 +0200 (CEST) Received: by mail-pg0-f68.google.com with SMTP id y129so29168051pgy.3 for ; Sun, 30 Jul 2017 19:31:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1501282874-127700-1-git-send-email-jianfeng.tan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 28, 2017 at 11:01:14PM +0000, Jianfeng Tan wrote: > When virtio-net devices are bound to uio_pci_generic, we get > the wrong mac addr by virtio PMD. The wrong mac addr is a > addr that is 4-byte left shift of the correct addr. > > It's a regression bug introduced by the cleanup patch below. > The condition of if we set use_msix should be if msix is > actually enabled. Only to check if there is a capability list > is not enough. For example, binding a transitional device > to uio_pci_device would trigger the wrong assignment of use_msix. > > To correct that, we also check the flags of msix capability to > make sure it's enabled. > > Fixes: ee1843bd8907 ("net/virtio: remove redundant MSI-X detection") > Cc: stable@dpdk.org > Cc: Zhihong Wang > Cc: Yuanhan Liu > Cc: Maxime Coquelin > > Reported-by: Vipin Varghese > Signed-off-by: Jianfeng Tan Applied to dpdk-next-virtio. Thanks. --yliu