From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Subject: [PATCH] net/virtio-user: send kick to tx queue to notify backend on initialization Date: Tue, 1 Aug 2017 09:17:36 -0700 Message-ID: <20170801161736.83502-1-sluong@cisco.com> Cc: dev@dpdk.org To: yliu@fridaylinux.org, maxime.coquelin@redhat.com Return-path: Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id C27D190F3 for ; Tue, 1 Aug 2017 18:17:36 +0200 (CEST) Received: by mail-pf0-f194.google.com with SMTP id c65so2891074pfl.0 for ; Tue, 01 Aug 2017 09:17:36 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acccording to the spec, https://fossies.org/linux/qemu/docs/specs/vhost-user.txt client must start ring upon receiving a kick (that is, detecting that file descriptor is reachable) on the descriptor specified by VHOST_USER_SET_VRING_KICK. The code sends a kick to the rx queue. It is missing sending a kick for the tx queue. This patch is to add the missing code to comply with the spec. Signed-off-by: Steven --- drivers/net/virtio/virtio_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 00a3122..6362e14 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1747,6 +1747,11 @@ virtio_dev_start(struct rte_eth_dev *dev) virtqueue_notify(rxvq->vq); } + for (i = 0; i < dev->data->nb_tx_queues; i++) { + txvq = dev->data->tx_queues[i]; + virtqueue_notify(txvq->vq); + } + PMD_INIT_LOG(DEBUG, "Notified backend at initialization"); for (i = 0; i < dev->data->nb_rx_queues; i++) { -- 2.10.1 (Apple Git-78)