From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiayu Hu <jiayu.hu@intel.com>
Subject: Re: [PATCH v2] doc: add prog_guide for the GRO library
Date: Fri, 4 Aug 2017 17:37:43 +0800
Message-ID: <20170804093743.GA28026@dpdk15.sh.intel.com>
References: <1499743655-86736-1-git-send-email-jiayu.hu@intel.com>
 <1501834844-25765-1-git-send-email-jiayu.hu@intel.com>
 <B27915DBBA3421428155699D51E4CFE23ED5A5B5@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id F38EC2C55
 for <dev@dpdk.org>; Fri,  4 Aug 2017 11:36:00 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23ED5A5B5@IRSMSX103.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi John,

On Fri, Aug 04, 2017 at 05:11:18PM +0800, Mcnamara, John wrote:
> > -----Original Message-----
> > From: Hu, Jiayu
> > Sent: Friday, August 4, 2017 9:21 AM
> > To: dev@dpdk.org
> > Cc: thomas@monjalon.net; Mcnamara, John <john.mcnamara@intel.com>; Hu,
> > Jiayu <jiayu.hu@intel.com>
> > Subject: [PATCH v2] doc: add prog_guide for the GRO library
> > 
> > Add prog_guide doc to explain the design of the GRO library.
> 
> > ...
> 
> > +Generic Receive Offload Library
> > +===============================
> > +
> > ...
> > +
> > +The GRO library assumes all inputted packets are with correct checksums.
> > +In addition, the GRO library doesn't re-calculate checksums for merged
> > +packets. If inputted packets are IP fragmented, the GRO library assumes
> > +they are complete packets (i.e. with L4 headers).
> 
> It is more correct/common to use input instead of inputted. You should
> make this change throughout the doc.

Thanks a lot and I will change them.

BRs,
Jiayu

> 
> Also this bout be better as:
> 
> The GRO library assumes all input packets have correct checksums. In addition, the GRO library doesn't re-calculate checksums for merged packets.
> 
> Apart from that:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>