From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH] eventdev: fix missing includes Date: Fri, 4 Aug 2017 12:20:35 +0200 Message-ID: <20170804102035.4051-1-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: jerin.jacob@caviumnetworks.com Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 183892C19 for ; Fri, 4 Aug 2017 12:20:49 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PCI helper file depends on some EAL definitions. Spotted with devtools/check-includes.sh: error: implicit declaration of function ‘rte_eal_process_type’ error: ‘RTE_PROC_PRIMARY’ undeclared error: implicit declaration of function ‘rte_socket_id’ There was also this error because the inline keyword was missing: error: ‘rte_event_pmd_pci_probe’ defined but not used Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional") Signed-off-by: Thomas Monjalon --- lib/Makefile | 2 +- lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Makefile b/lib/Makefile index 86caba17b..22962910d 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether DEPDIRS-librte_ip_frag += librte_hash DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro -DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net +DEPDIRS-librte_gro := librte_eal librte_mbuf DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += librte_jobstats DEPDIRS-librte_jobstats := librte_eal DIRS-$(CONFIG_RTE_LIBRTE_METRICS) += librte_metrics diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h index 1dbba373c..b6bd7319e 100644 --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h @@ -47,6 +47,8 @@ extern "C" { #include +#include +#include #include #include "rte_eventdev_pmd.h" @@ -58,7 +60,7 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev); * Wrapper for use by pci drivers as a .probe function to attach to a event * interface. */ -static int +static inline int rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev, size_t private_data_size, -- 2.13.2