From mboxrd@z Thu Jan 1 00:00:00 1970 From: luca.boccassi@gmail.com Subject: [PATCH v5 5/6] mk: sort object files when building deps lists Date: Thu, 10 Aug 2017 19:23:24 +0100 Message-ID: <20170810182325.14058-6-luca.boccassi@gmail.com> References: <20170628135702.18150-1-lboccass@brocade.com> <20170810182325.14058-1-luca.boccassi@gmail.com> Cc: Luca Boccassi To: dev@dpdk.org Return-path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id E31326841 for ; Thu, 10 Aug 2017 20:24:24 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id c24so1096172wra.2 for ; Thu, 10 Aug 2017 11:24:24 -0700 (PDT) In-Reply-To: <20170810182325.14058-1-luca.boccassi@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Luca Boccassi In order to achieve reproducible builds, always use the same order when listing object files to build dependencies lists. Signed-off-by: Luca Boccassi --- mk/rte.app.mk | 4 ++-- mk/rte.hostapp.mk | 4 ++-- mk/rte.shared.mk | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index c25fdd9f5..c5b8c1ead 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -270,8 +270,8 @@ LDLIBS_NAMES += $(patsubst -Wl$(comma)-l%,lib%.a,$(filter -Wl$(comma)-l%,$(LDLIB # list of found libraries files (useful for deps). If not found, the # library is silently ignored and dep won't be checked -LDLIBS_FILES := $(wildcard $(foreach dir,$(LDLIBS_PATH),\ - $(addprefix $(dir)/,$(LDLIBS_NAMES)))) +LDLIBS_FILES := $(sort $(wildcard $(foreach dir,$(LDLIBS_PATH),\ + $(addprefix $(dir)/,$(LDLIBS_NAMES))))) # # Compile executable file if needed diff --git a/mk/rte.hostapp.mk b/mk/rte.hostapp.mk index 5cb4909cb..f58173c31 100644 --- a/mk/rte.hostapp.mk +++ b/mk/rte.hostapp.mk @@ -69,9 +69,9 @@ O_TO_EXE_DO = @set -e; \ -include .$(HOSTAPP).cmd # list of .a files that are linked to this application -LDLIBS_FILES := $(wildcard \ +LDLIBS_FILES := $(sort $(wildcard \ $(addprefix $(RTE_OUTPUT)/lib/, \ - $(patsubst -l%,lib%.a,$(filter -l%,$(LDLIBS))))) + $(patsubst -l%,lib%.a,$(filter -l%,$(LDLIBS)))))) # # Compile executable file if needed diff --git a/mk/rte.shared.mk b/mk/rte.shared.mk index 87ccf0ba4..4e680bc03 100644 --- a/mk/rte.shared.mk +++ b/mk/rte.shared.mk @@ -85,8 +85,8 @@ LDLIBS_NAMES += $(patsubst -Wl$(comma)-l%,lib%.a,$(filter -Wl$(comma)-l%,$(LDLIB # list of found libraries files (useful for deps). If not found, the # library is silently ignored and dep won't be checked -LDLIBS_FILES := $(wildcard $(foreach dir,$(LDLIBS_PATH),\ - $(addprefix $(dir)/,$(LDLIBS_NAMES)))) +LDLIBS_FILES := $(sort $(wildcard $(foreach dir,$(LDLIBS_PATH),\ + $(addprefix $(dir)/,$(LDLIBS_NAMES))))) # # Archive objects in .so file if needed -- 2.11.0