From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF Date: Thu, 17 Aug 2017 17:32:27 -0700 Message-ID: <20170817173227.29bae83d@xeon-e3> References: <1500929487-72896-1-git-send-email-wenzhuo.lu@intel.com> <1502994823-125017-1-git-send-email-wenzhuo.lu@intel.com> <1502994823-125017-2-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Wenzhuo Lu Return-path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id 5A5869109 for ; Fri, 18 Aug 2017 02:32:37 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id t80so25480103pgb.5 for ; Thu, 17 Aug 2017 17:32:37 -0700 (PDT) In-Reply-To: <1502994823-125017-2-git-send-email-wenzhuo.lu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 18 Aug 2017 02:33:42 +0800 Wenzhuo Lu wrote: > Currently, rte_eth_dev_mac_addr_add is used by a > testpmd CLI to add a MAC address for VF. But the > parameter 'pool' of this API means the VMDq pool, > not VF. > So, it's wrong to use it to add the VF MAC address. > This patch provides a new API that can be used to > add VF MAC address on i40e. > > Signed-off-by: Wenzhuo Lu What do other drivers do? Sorry, a driver specific API is (almost) always the wrong solution.