From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH v2 1/3] ethdev: expose Rx hardware timestamp
Date: Thu, 24 Aug 2017 15:47:54 +0200
Message-ID: <20170824134754.GL4544@autoinstall.dev.6wind.com>
References: <1503409570-9946-3-git-send-email-rasland@mellanox.com>
 <1503560793-21597-1-git-send-email-rasland@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: thomas@monjalon.net, jingjing.wu@intel.com, dev@dpdk.org,
 adrien.mazarguil@6wind.com
To: Raslan Darawsheh <rasland@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 4D6C37CB6
 for <dev@dpdk.org>; Thu, 24 Aug 2017 15:48:04 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id m207so5865774wma.1
 for <dev@dpdk.org>; Thu, 24 Aug 2017 06:48:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1503560793-21597-1-git-send-email-rasland@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Aug 24, 2017 at 10:46:31AM +0300, Raslan Darawsheh wrote:
> Added new capability to the list of rx offloads for hw timestamp
> 
> The PMDs how expose this capability will always have it enabled.

Not sure this comment is accurate, Rx offloads are application request, PMD
does not have to enable it by default.

> But, if the following API got accepted applications can choose
> between disable/enable this API.
> http://dpdk.org/dev/patchwork/patch/27470/
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
>  lib/librte_ether/rte_ethdev.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 0adf327..cc5d281 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -907,6 +907,8 @@ struct rte_eth_conf {
>  #define DEV_RX_OFFLOAD_QINQ_STRIP  0x00000020
>  #define DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM 0x00000040
>  #define DEV_RX_OFFLOAD_MACSEC_STRIP     0x00000080
> +#define DEV_RX_OFFLOAD_TIMESTAMP 0x00000100
> +/**< Device puts raw timestamp in mbuf. */
>  
>  /**
>   * TX offload capabilities of a device.
> -- 
> 2.7.4

-- 
Nélio Laranjeiro
6WIND